Support solaris simplepipe for triggerReleasePipeline.sh #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <andrew.m.leonard@ibm.com>
sxa
approved these changes
Aug 26, 2025
Member
sxa
left a comment
sxa
left a comment
There was a problem hiding this comment.
I feel it would have been better to change the Solaris pipelines around to accept this parameter, but as you suggested elsewhere that would probably have been a bit more work so I'm ok with this for now. Maybe something for the future for consistency ... (Perhaps a new issue on that would be in order).
Approving - I'll let you decide on updating the doc as per the review comment.
| JDKVERSION="$1" | ||
| ADOPTIUM_REPO=${2:-"https://github.com/adoptium/$JDKVERSION.git"} | ||
| BRANCH=${3:-"master"} | ||
| SOLARIS=${4:-"normal"} |
Member
There was a problem hiding this comment.
Possibly want to update line 25 which mentions the parameters to include this one.
Contributor
Author
|
Raised issue to look at making Solaris SCM_REF to scmReference : adoptium/temurin-build#4234 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support triggering Solaris simplepipe using SCM_REF
Solaris simplepipe is significantly different to the main pipelines, and use SCM_REF rather than scmReference. To save having to change all the existing EA beta trigger, use the same as they do, SCM_REF.