Rework mail move logic

[flokli]

Currently, when moving files, we move the file in the filesystem and shell out to notmuch new, and pick up new file locations in doing that.

This causes problems, as users often call afew via notmuch's hook system, and in general, it's a bit invasive operation.

A better way would be to do the following on mail move:

• Copy the file to the new location
• Call notmuch.database.add_message() with the new location
• Remove the file on the old location
• Call notmuch.database.remove_message() with the old location

This would supersede #187, and fix #139.

[GuillaumeSeren]

Hey @flokli ,
I think the logic is better than calling a big 'notmuch new',
but it is a quite different from the #187 approach,
so the PR has to be changed a lot,
so I am checking if I can work a small patch to do it.

[GuillaumeSeren]

I have started to work on the patch last night,
it went well but 'add_message()' is deprecated so I have to use index_file(),
and actually the hard part is the filename param is

        :param filename: should be a path relative to the path of the
            open database (see :meth:`get_path`), or else should be an
            absolute filename with initial components that match the
            path of the database.

Which will probably a bit more work to get done, but I am on it.

see: https://git.notmuchmail.org/git?p=notmuch;a=blob;f=bindings/python/notmuch/database.py;h=342d665a224761a2557ea00233f7d99c7dbae321;hb=HEAD#l426

[GuillaumeSeren]

Hey !
So I've finished a working patch, I tested it on my setup it work well,
if you can test and/or send feedback it would be great !

[mjg]

Caveat: This patch ignores the "rename" setting! Had to clean up quite a few mbsync problems because of that.

Also, maybe it could be rebased and cut into smaller chunks that are easier to review?

[GuillaumeSeren]

Hey,
@mjg thank you for testing this patch it need more reviews, can you develop a bit more your problem with the rename setting ?

I've just rebased the branch please respond on #189 to help improve this patch.