[error] Failed to publish node 9333: PDS request failed (500): InternalServerError — Internal Server Error

[lieb77]

drush queue:run atmosphere_publish
[error] Failed to publish node 9333: PDS request failed (500): InternalServerError — Internal Server Error
[error] Failed to publish node 9333: PDS request failed (500): InternalServerError — Internal Server Error
[error] Failed to publish node 9333: PDS request failed (500): InternalServerError — Internal Server Error
...

It kept going until I hit ctrl-c to stop it.

This was on a new Article. The problem is it actually succeeded in creating the posts, but kept retrying until it had actually created 20+ copies of the same post in both app.bsky.feed.post and site.standard.document. I had to use goat to delete them all.

[lieb77]

I think I found the PDS log entry corresponding to these.

"req": {
    "id": 47956,
    "method": "POST",
    "url": "/xrpc/com.atproto.repo.applyWrites",
    "query": {},
    "params": {},
    "headers": {
      "host": "banjo.paullieberman.org",
      "x-real-ip": "107.182.235.102",
      "x-forwarded-for": "107.182.235.102",
      "x-forwarded-proto": "https",
      "connection": "upgrade",
      "content-length": "3298",
      "user-agent": "Drupal/11.3.6 (+https://www.drupal.org/) GuzzleHttp/7",
      "content-type": "application/json",
      "authorization": "DPoP did:plc:ntnmdg6fuvogzr6khf7agoqf",
      "dpop": "eyJhbGciOiJFUzI1NiIsInR5cCI6ImRwb3Arand0IiwiandrIjp7Imt0eSI6IkVDIiwiY3J2IjoiUC0yNTYiLCJ4IjoiSWlyWnNxQURCVzRkR09KQy16Vk9FN1NVNnhCNU5GQVlPVGhxVU45ZU9qayIsInkiOiJSZFQwajRzV0FfVjVqTmFrMnVlaHpGN3Y3UkEyel8tZXlRV2tHMy1kbTVnIn19.eyJqdGkiOiI4NjE4ZDE2ZjA0N2RlNDM3OThiYTk4NDMwZTBhNTg4MiIsImh0bSI6IlBPU1QiLCJodHUiOiJodHRwczpcL1wvYmFuam8ucGF1bGxpZWJlcm1hbi5vcmdcL3hycGNcL2NvbS5hdHByb3RvLnJlcG8uYXBwbHlXcml0ZXMiLCJpYXQiOjE3NzYxMjg3MzQsIm5vbmNlIjoidFlxSzZPczRGSVFEMUlTNXhKMFFHVEM1S19hdmhIN1Y1NnJ3MXVrOTJMYyIsImF0aCI6IlY3X2FEeFRZc2RSVVNWWWMwUXJLY05saGxWQzhmZ1FxMElLSk1OZmx2MDAifQ.obfuscated"
    }
  },
  "res": {
    "statusCode": 500,
    "headers": {
      "x-powered-by": "Express",
      "access-control-allow-origin": "*",
      "cache-control": "private",
      "vary": "Authorization, Accept-Encoding",
      "dpop-nonce": "tYqK6Os4FIQD1IS5xJ0QGTC5K_avhH7V56rw1uk92Lc",
      "access-control-expose-headers": "DPoP-Nonce",
      "content-type": "application/json; charset=utf-8",
      "content-length": "65",
      "etag": "W/\"41-PDrLQG9BpCN547AVB5jtYl3RBt8\""
    }
  },
  "err": {
    "message": "failed with status code 500"
  },
  "responseTime": 19,
  "msg": "request errored"
}

[mackh]

thanks, we will review

[lieb77]

Here is my best guess at what was happening. Look for comments with -PL

 
 
Queworker/AtmospherePublish
  /**
   * {@inheritdoc}
   */
  public function processItem($data): void {
    $nid = $data['nid'] ?? NULL;
    if (!$nid) {
      return;
    }

    $node = $this->entityTypeManager->getStorage('node')->load($nid);
    if (!$node instanceof NodeInterface || !$node->isPublished()) {
      return;
    }

    try {
      $this->publisher->publish($node);
      $this->logger->info('Published node @nid to AT Protocol.', ['@nid' => $nid]);
    }
    catch (\Exception $e) {
      $this->logger->error('Failed to publish node @nid: @message', [
        '@nid' => $nid,
        '@message' => $e->getMessage(),
      ]);
      
      // This is causing  an endless loop - PL
      throw new RequeueException('Publish failed, will retry.');
    }
    
Service/Publisher

 public function publish(NodeInterface $node): array {
    $bskyRecord = $this->postTransformer->transform($node);
    $docRecord = $this->documentTransformer->transform($node);

    $bskyRkey = $this->postTransformer->getRkey($node);
    $docRkey = $this->documentTransformer->getRkey($node);

    // Atomic write of both records.
    $writes = [
      [
        '$type' => 'com.atproto.repo.applyWrites#create',
        'collection' => $this->postTransformer->getCollection(),
        'rkey' => $bskyRkey,
        'value' => $bskyRecord,
      ],
      [
        '$type' => 'com.atproto.repo.applyWrites#create',
        'collection' => $this->documentTransformer->getCollection(),
        'rkey' => $docRkey,
        'value' => $docRecord,
      ],
    ];

	// My guess is that this succeeds -PL
    $result = $this->apiClient->applyWrites($writes);

    // Store result metadata back to the node.
    $this->storeResults($node, $result);

    // Follow-up: update document with bskyPostRef now that we have the CID.
    $bskyUri = $node->get('atmosphere_bsky_uri')->value ?? '';
    $bskyCid = $node->get('atmosphere_bsky_cid')->value ?? '';
    if (!empty($bskyUri) && !empty($bskyCid)) {
      $docRecord['bskyPostRef'] = [
        'uri' => $bskyUri,
        'cid' => $bskyCid,
      ];

      try {
      	// But this fails - PL
        $this->apiClient->putRecord(
          $this->documentTransformer->getCollection(),
          $docRkey,
          $docRecord,
        );
      }
      catch (\Exception $e) {
        $this->logger->warning('Failed to update document with bskyPostRef: @message', [
          '@message' => $e->getMessage(),
        ]);
      }
    }

    return $result;
  }