Skip to content

classifier in build.gradle #66

@pelsmi11

Description

@pelsmi11

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-firebase-push-notifications@2.0.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-firebase-push-notifications/android/build.gradle b/node_modules/react-native-firebase-push-notifications/android/build.gradle
index d78d9ce..8c7665d 100644
--- a/node_modules/react-native-firebase-push-notifications/android/build.gradle
+++ b/node_modules/react-native-firebase-push-notifications/android/build.gradle
@@ -182,12 +182,12 @@ afterEvaluate { project ->
     }
 
     task androidJavadocJar(type: Jar, dependsOn: androidJavadoc) {
-        classifier = 'javadoc'
+        archiveClassifier.set('javadoc')
         from androidJavadoc.destinationDir
     }
 
     task androidSourcesJar(type: Jar) {
-        classifier = 'sources'
+        archiveClassifier.set('sources')
         from android.sourceSets.main.java.srcDirs
         include '**/*.java'
     }
diff --git a/node_modules/react-native-firebase-push-notifications/android/build/intermediates/aar_metadata/debug/writeDebugAarMetadata/aar-metadata.properties b/node_modules/react-native-firebase-push-notifications/android/build/intermediates/aar_metadata/debug/writeDebugAarMetadata/aar-metadata.properties
new file mode 100644
index 0000000..1211b1e
--- /dev/null
+++ b/node_modules/react-native-firebase-push-notifications/android/build/intermediates/aar_metadata/debug/writeDebugAarMetadata/aar-metadata.properties
@@ -0,0 +1,6 @@
+aarFormatVersion=1.0
+aarMetadataVersion=1.0
+minCompileSdk=1
+minCompileSdkExtension=0
+minAndroidGradlePluginVersion=1.0.0
+coreLibraryDesugaringEnabled=false
diff --git a/node_modules/react-native-firebase-push-notifications/android/src/main/java/com/afrihost/firebase/notifications/DisplayNotificationTask.java b/node_modules/react-native-firebase-push-notifications/android/src/main/java/com/afrihost/firebase/notifications/DisplayNotificationTask.java
index 7292785..c0c8989 100644
--- a/node_modules/react-native-firebase-push-notifications/android/src/main/java/com/afrihost/firebase/notifications/DisplayNotificationTask.java
+++ b/node_modules/react-native-firebase-push-notifications/android/src/main/java/com/afrihost/firebase/notifications/DisplayNotificationTask.java
@@ -137,7 +137,7 @@ public class DisplayNotificationTask extends AsyncTask<Void, Void, Void> {
         if (bigPicture.containsKey("largeIcon")) {
           String largeIconStr = bigPicture.getString("largeIcon");
           if (largeIconStr == null) {
-            bp = bp.bigLargeIcon(null);
+            bp = bp.bigLargeIcon((Bitmap) null);
           } else {
             Bitmap largeIconBitmap = getBitmap(largeIconStr);
             if (largeIconBitmap != null) {

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions