-
Notifications
You must be signed in to change notification settings - Fork 2
fix: conversation mode missing obs logging + cross-squad data flow broken #700
Description
Problem
Two gaps in conversation mode prevent proper cycle evaluation and cross-squad coordination.
1. No observability logging from conversations
workflow.ts runs conversations via claude --print --allowedTools but never writes to the observability JSONL. The squads review command can't see conversation cycle runs — "Last Run" shows stale data.
Fix: After each conversation completes, write an ObservabilityRecord to JSONL with: squad, turn count, estimated cost, converged/stopped, duration. Use logObservability() from observability.ts.
2. Cross-squad data flow not working
shared/learnings.md — all 14 files are from March 9 (22 days stale). No agent updates them. The context_from mechanism in agent frontmatter loads these files, but they contain nothing useful.
Wave memory commits — the git commit between waves captures state.md changes, but Wave 2 agents don't read Wave 1's state files. They only read their own state + stale learnings.
Fix:
- Add to SYSTEM.md or conversation-roles.md: leads must write key findings to
shared/learnings.mdat end of run - Or: auto-extract a summary from the conversation transcript and write it to shared/learnings.md after each conversation completes
3. Goals not updated in conversation mode
Leads in conversations produce text output but don't reliably update goals.md. The verifier checks work quality but nobody checks if goals.md was updated.
Fix: After conversation completes, check if goals.md was modified. If not, log a warning.
Impact
squads reviewshows stale data after conversation cycles- Waves run in the right order but don't share information between them
- Goal progress tracking is broken for conversation mode