Skip to content

fix: use the sessionId of sandbox instead of random string, so we can… #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qijiang17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use the sessionId of sandbox instead of random string, so we can… #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sandbox-core/src/main/java/io/agentscope/runtime/sandbox/manager/SandboxService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public ContainerModel createContainer(Sandbox sandbox) throws JsonProcessingExce
logger.info("Docker image is ready: {}", imageName);
}

String sessionId = RandomStringGenerator.generateRandomString(22);
String sessionId = sandbox.getSessionId();
Copy link

@gemini-code-assist gemini-code-assist bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The sessionId obtained here is used on line 164 to construct a directory path. As the PR description indicates, the sessionId can come from a user-controlled source like a URL path parameter. This creates a critical path traversal vulnerability. A malicious user could provide a sessionId like ../../sensitive-data to create directories and potentially mount host paths outside of the intended sessions_mount_dir.

To mitigate this, you must validate the sessionId to prevent path traversal. Here is a robust way to do it using java.nio.file.Path:

// After getting the sessionId
Path mountPath = Paths.get(currentDir, default_mount_dir, sessionId).toAbsolutePath().normalize();
Path basePath = Paths.get(currentDir, default_mount_dir).toAbsolutePath().normalize();

if (!mountPath.startsWith(basePath)) {
    throw new IllegalArgumentException("Invalid sessionId, potential path traversal attempt.");
}

String mountDir = mountPath.toString();
// ... then use mountDir

This ensures that the resolved path for the session's mount directory is always inside the expected base directory.

String currentDir = System.getProperty("user.dir");
String mountDir = currentDir + "/" + default_mount_dir + "/" + sessionId;

Expand Down
Loading