Missing address, when using browseThemAll?

[ajmas]

Description

I am trying to create a small browser, but I am finding that the responses with browseThemAll() aren't including addresses

const allTheTypes = mdns.browseThemAll({});
allTheTypes.on('serviceUp', service => {
  console.log('service up', service.addresses, service);
});

As reference when used by itself this does work:

    const browser = mdns.createBrowser(mdns.tcp('smb'));
    browser.on('serviceUp', service => {
        console.log('service up: ', service);
    });
    browser.on('serviceDown', service => {
        console.log('service down: ', service);
    });

Since this worked, I tried the following, and while it does provide values for both host and addresses, I am wondering whether this is the way we need to be doing things:

    const browserByType: Record<string, Browser> = {};
    const allTheTypes = mdns.browseThemAll({ });
    allTheTypes.on('serviceUp', service => {
        const serviceType = service.type;
        const type = `${serviceType.name}.${serviceType.protocol}`;
        if (!browserByType[type]) {
            if (service.type.protocol == 'tcp') {
                console.log(`Creating browser for ${serviceType.name}`);
                const subBrowser = mdns.createBrowser(mdns.tcp(serviceType.name));
                // Not getting any events generated here:
                subBrowser.on('serviceUp', service => {
                    console.log('XXX service up', service);
                })
                subBrowser.start();
                browserByType[type] = subBrowser;
            } 
       }
   });

Version Info

OS: macOS 15.6.1
node: v20.19.0
mdns: 2.7.2

[agnat]

Hi AJ,

Yes, that is exactly how it is supposed to work. Internally the function uses a magic service type that acts as a glob or wildcard. It only reports present service types, not the actual services (hosts). It directly wraps a core mdns feature and I think all full mdns browsers have to jump through that extra hoop, at least on OSX.

I don’t think a more elaborate API is needed or justified because in practice you never need it. The feature is exposed only for completeness. You’ve already (almost) written the only program that it is useful for: an mdns browser.