-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed
Description
Affected code
music_notes/lib/src/note/enharmonic_note.dart
Lines 83 to 88 in 92cee2d
| // TODO(albertms10): return the note with the closest accidental #50. | |
| .sorted( | |
| (a, b) => a.accidental.semitones | |
| .abs() | |
| .compareTo(b.accidental.semitones.abs()), | |
| ) |
Failing tests
Note
Addressed in #88.
music_notes/test/src/tonality/key_signature_test.dart
Lines 119 to 124 in 92cee2d
| expect(const KeySignature(10, Accidental.sharp).tonalities, { | |
| const Tonality(Note.aSharp, Modes.major), | |
| // TODO(albertms10): Failing test #50: | |
| // Should be `Note(Notes.f, Accidental.doubleSharp)`. | |
| const Tonality(Note.g, Modes.minor), | |
| }); |
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinghelp wantedExtra attention is neededExtra attention is needed
Projects
Status
Todo