use Record<TK, TV> instead of array type to setup scratch space in tests to simplify the setup

Author: boblat

src/impl/scratch.ts

@@ -8,7 +8,7 @@ export const gloadUint64: internal.opTypes.GloadUint64Type = (
   const txn = lazyContext.activeGroup.getTransaction(a)
   const result = txn.getScratchSlot(b)
   if (result instanceof internal.primitives.Uint64Cls) {
-    return result as uint64
+    return result.asAlgoTs()
   }
   throw new internal.errors.InternalError('invalid scratch slot type')
 }
@@ -20,7 +20,7 @@ export const gloadBytes: internal.opTypes.GloadBytesType = (
   const txn = lazyContext.activeGroup.getTransaction(a)
   const result = txn.getScratchSlot(b)
   if (result instanceof internal.primitives.BytesCls) {
-    return result as bytes
+    return result.asAlgoTs()
   }
   throw new internal.errors.InternalError('invalid scratch slot type')
 }

src/impl/transactions.ts

@@ -233,7 +233,7 @@ export type ApplicationTransactionFields = TxnFields<gtxn.ApplicationTxn> &
     approvalProgramPages: Array<bytes>
     clearStateProgramPages: Array<bytes>
     appLogs: Array<bytes>
-    scratchSpace: Array<bytes | uint64>
+    scratchSpace: Record<number, bytes | uint64>
   }>
 
 export class ApplicationTransaction extends TransactionBase implements gtxn.ApplicationTxn {
@@ -266,7 +266,7 @@ export class ApplicationTransaction extends TransactionBase implements gtxn.Appl
     this.#apps = fields.apps ?? []
     this.#approvalProgramPages = fields.approvalProgramPages ?? (fields.approvalProgram ? [fields.approvalProgram] : [])
     this.#clearStateProgramPages = fields.clearStateProgramPages ?? (fields.clearStateProgram ? [fields.clearStateProgram] : [])
-    fields.scratchSpace?.forEach((v, i) => this.setScratchSlot(i, v))
+    Object.entries(fields.scratchSpace ?? {}).forEach(([k, v]) => this.setScratchSlot(Number(k), v))
   }
 
   readonly appId: Application

tests/state-op-codes.spec.ts

@@ -367,10 +367,7 @@ describe('State op codes', async () => {
       [3, Uint64(42)],
       [255, Bytes('max_index')],
     ])('should return the correct field value of the scratch slot', async (index: number, value: bytes | uint64) => {
-      const newScratchSpace = Array(256).fill(Uint64(0))
-      newScratchSpace[index] = value
-
-      ctx.txn.createScope([ctx.any.txn.applicationCall({ scratchSpace: newScratchSpace })]).execute(() => {})
+      ctx.txn.createScope([ctx.any.txn.applicationCall({ scratchSpace: { [index]: value } })]).execute(() => {})
 
       expect(ctx.txn.lastGroup.getScratchSlot(index)).toEqual(value)