fix: runtime-helper does not truly handles augmented assignment so strip = sign from operator before calling it

Author: boblat

src/runtime-helpers.ts

@@ -20,30 +20,7 @@ export function switchableValue(x: unknown): bigint | string | boolean {
 //   internalError(`Cannot wrap ${nameOfType(x)}`)
 // }
 
-type BinaryOps =
-  | '+'
-  | '-'
-  | '*'
-  | '**'
-  | '/'
-  | '%'
-  | '>'
-  | '>='
-  | '<'
-  | '<='
-  | '==='
-  | '!=='
-  | '<<'
-  | '>>'
-  | '&'
-  | '|'
-  | '^'
-  | '+='
-  | '-='
-  | '/='
-  | '*='
-  | '**='
-  | '%='
+type BinaryOps = '+' | '-' | '*' | '**' | '/' | '%' | '>' | '>=' | '<' | '<=' | '===' | '!==' | '<<' | '>>' | '&' | '|' | '^'
 type UnaryOps = '~'
 
 function tryGetBigInt(value: unknown): bigint | undefined {
@@ -95,25 +72,19 @@ function uint64BinaryOp(left: DeliberateAny, right: DeliberateAny, op: BinaryOps
   const result = (function () {
     switch (op) {
       case '+':
-      case '+=':
         return lbi + rbi
       case '-':
-      case '-=':
         return lbi - rbi
       case '*':
-      case '*=':
         return lbi * rbi
       case '**':
-      case '**=':
         if (lbi === 0n && rbi === 0n) {
           throw internal.errors.codeError('0 ** 0 is undefined')
         }
         return lbi ** rbi
       case '/':
-      case '/=':
         return lbi / rbi
       case '%':
-      case '%=':
         return lbi % rbi
       case '>>':
         if (rbi > 63n) {
@@ -156,25 +127,19 @@ function bigUintBinaryOp(left: DeliberateAny, right: DeliberateAny, op: BinaryOp
   const result = (function () {
     switch (op) {
       case '+':
-      case '+=':
         return lbi + rbi
       case '-':
-      case '-=':
         return lbi - rbi
       case '*':
-      case '*=':
         return lbi * rbi
       case '**':
-      case '**=':
         if (lbi === 0n && rbi === 0n) {
           throw internal.errors.codeError('0 ** 0 is undefined')
         }
         return lbi ** rbi
       case '/':
-      case '/=':
         return lbi / rbi
       case '%':
-      case '%=':
         return lbi % rbi
       case '>>':
         throw new internal.errors.CodeError('BigUint does not support >> operator')
@@ -242,25 +207,19 @@ function bytesBinaryOp(left: DeliberateAny, right: DeliberateAny, op: BinaryOps)
 function defaultBinaryOp(left: DeliberateAny, right: DeliberateAny, op: BinaryOps): DeliberateAny {
   switch (op) {
     case '+':
-    case '+=':
       return left + right
     case '-':
-    case '-=':
       return left - right
     case '*':
-    case '*=':
       return left * right
     case '**':
-    case '**=':
       if (left === 0n && right === 0n) {
         throw new internal.errors.CodeError('0 ** 0 is undefined')
       }
       return left ** right
     case '/':
-    case '/=':
       return left / right
     case '%':
-    case '%=':
       return left % right
     case '>>':
       if (typeof left === 'bigint' && typeof right === 'bigint') {

src/test-transformer/node-factory.ts

@@ -34,7 +34,7 @@ export const nodeFactory = {
       factory.createCallExpression(
         factory.createPropertyAccessExpression(factory.createIdentifier('runtimeHelpers'), factory.createIdentifier('binaryOp')),
         undefined,
-        [left, right, factory.createStringLiteral(op)],
+        [left, right, factory.createStringLiteral(op.replace('=', ''))],
       ),
     )
   },