fix: clone should return value if properties are in different order

Author: boblat

src/impl/encoded-types/encoded-types.ts

@@ -1314,7 +1314,13 @@ export const getArc4Encoded = (value: DeliberateAny, sourceTypeInfoString?: stri
       name: `Struct<${value.constructor.name}>`,
       genericArgs: Object.fromEntries(Object.keys(value).map((x, i) => [x, genericArgs[i]])),
     }
-    return new Struct(typeInfo, Object.fromEntries(Object.keys(value).map((x, i) => [x, result[i]])))
+    let s = Object.fromEntries(Object.keys(typeInfo.genericArgs).map((x, i) => [x, result[i]]))
+    // if source type info is provided, reorder the struct properties to match the expected type schema
+    if (propTypeInfos) {
+      s = Object.fromEntries(Object.keys(propTypeInfos).map((x) => [x, s[x]]))
+      typeInfo.genericArgs = propTypeInfos
+    }
+    return new Struct(typeInfo, s)
   }
 
   throw new CodeError(`Unsupported type for encoding: ${typeof value}`)

tests/native-mutable-object.algo.spec.ts

@@ -789,4 +789,14 @@ describe('native mutable object', () => {
       assertMatch(decoded, obj)
     })
   })
+
+  describe('clone', () => {
+    it('should work when property order is different', () => {
+      const obj1: NestedObj = { a: 1, b: true, c: 'hello', d: { x: 10, y: 'world', z: true } }
+      const obj2: NestedObj = { d: { x: 10, z: true, y: 'world' }, a: 1, c: 'hello', b: true }
+
+      expect(clone(obj2)).toEqual(obj2)
+      expect(clone(obj2)).toEqual(obj1)
+    })
+  })
 })