refactor: use more appropriate error classes

Author: boblat

src/context-helpers/context-util.ts

@@ -1,20 +1,20 @@
 import type { uint64 } from '@algorandfoundation/algorand-typescript'
 import type { AbiMetadata } from '../abi-metadata'
-import { CodeError } from '../errors'
+import { AssertError } from '../errors'
 import { ApplicationTransaction } from '../impl/transactions'
 import { lazyContext } from './internal-context'
 
 export const checkRoutingConditions = (appId: uint64, metadata: AbiMetadata) => {
   const appData = lazyContext.getApplicationData(appId)
   const isCreating = appData.isCreating
   if (isCreating && metadata.onCreate === 'disallow') {
-    throw new CodeError('method can not be called while creating')
+    throw new AssertError('method can not be called while creating')
   }
   if (!isCreating && metadata.onCreate === 'require') {
-    throw new CodeError('method can only be called while creating')
+    throw new AssertError('method can only be called while creating')
   }
   const txn = lazyContext.activeGroup.activeTransaction
   if (txn instanceof ApplicationTransaction && metadata.allowActions && !metadata.allowActions.includes(txn.onCompletion)) {
-    throw new CodeError(`method can only be called with one of the following on_completion values: ${metadata.allowActions.join(', ')}`)
+    throw new AssertError(`method can only be called with one of the following on_completion values: ${metadata.allowActions.join(', ')}`)
   }
 }

src/impl/box.ts

@@ -2,7 +2,7 @@ import type { bytes, op, uint64 } from '@algorandfoundation/algorand-typescript'
 import { MAX_BOX_SIZE } from '../constants'
 import { lazyContext } from '../context-helpers/internal-context'
 import { toBytes } from '../encoders'
-import { InternalError } from '../errors'
+import { AvmError, InternalError } from '../errors'
 import { asBytes, asBytesCls, asNumber, asUint8Array, conactUint8Arrays } from '../util'
 import type { StubBytesCompat, StubUint64Compat } from './primitives'
 
@@ -11,7 +11,7 @@ export const Box: typeof op.Box = {
     const name = asBytes(a)
     const size = asNumber(b)
     if (name.length === 0 || size > MAX_BOX_SIZE) {
-      throw new InternalError('Invalid box name or size')
+      throw new AvmError('Invalid box name or size')
     }
     const app = lazyContext.activeApplication
     if (lazyContext.ledger.boxExists(app, name)) {