Skip to content

add inline comments and rubric.md #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ebirving wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add inline comments and rubric.md #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ <h4>Name the color below:</h4>
<button class="hintButton">Hint</button>
<button class="skip">Skip</button>
<a href="http://html-color-codes.info/color-names/">Click here for a full list of CSS3 color keywords</a>
<!-- A target="blank" here (to open the link in a new tab/window) would be a nice bit of UX -->
</div>
<h4 id="answeredQuestions">Correct: 0</h4>
<h4 id="totalQuestions"></h4>
Expand Down
26 changes: 26 additions & 0 deletions rubric.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Project Feedback + Evaluation

## Project Workflow

>Did you complete the user stories, wireframes, task tracking, and/or ERDs, as specified above? Did you use source control as expected for the phase of the program you’re in (detailed above)?

**Meets/Exceeds Expectations** Nice readme, especially your Approach and Unsolved Problems sections! As projects get more complex, you'll want to be sure to include more detailed installation instructions for someone who wants to install a local version of your full stacks. For a browser-only app like this, though, you're good to go.

## Technical Requirements

>Did you deliver a project that met all the technical requirements? Given what the class has covered so far, did you build something that was reasonably complex?

**Meets Expectations** This is a clean, full-featured game with nice UI (love the big color circle!). Deployed successfully. I'd love you see you implement the features mentioned in your readme. Well done!

## Code Quality

>Did you follow code style guidance and best practices covered in class, such as spacing, modularity, and semantic naming? Did you comment your code as your instructors have in class?

**Meets Expectations** Great comments, formatting, and semantic naming. It's really quite DRY as it is! A couple of spacing issues, but well done!


## Problem Solving

>Are you able to defend why you implemented your solution in a certain way? Can you demonstrate that you thought through alternative implementations?

**Meets Expectations** Really nice work, Alice! Your solution shows a real attention to detail and precision. I enjoyed playing it :+1:
3 changes: 2 additions & 1 deletion script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ $(document).ready(function(){
gainsboro = {
colorBoxColor:"____boro",
hint:"gainsboro"
}
}//(ERICA) Are color and hint reversed for this one??
];

//start
Expand Down Expand Up @@ -100,4 +100,5 @@ $(document).ready(function(){
$(".answer").val("");
$(".helpDisplay").html("");
});
//One way to make this even DRY-er would be to pull out the lines of code that are repeated in both Skip and Submit, and wrap them in a function that can be called in both, similar to next.
});