From 7069bfbf19e81d7c0a4aef23cca02dd0b61dfcdc Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 25 Oct 2022 02:50:04 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- tests/test_readme.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/tests/test_readme.py b/tests/test_readme.py index add727c..a7ae589 100644 --- a/tests/test_readme.py +++ b/tests/test_readme.py @@ -26,7 +26,26 @@ def setUp(self) -> None: # unpack print("unpacking....") with tarfile.open("/tmp/longformer-base-4096.tar.gz") as tar: - tar.extractall("/tmp") + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, "/tmp") def test_something(self): config = LongformerConfig.from_pretrained(self.model_dir)