From c1f5229db14a4f19178eb8dafcd8067893d6d008 Mon Sep 17 00:00:00 2001 From: Clara Meister Date: Fri, 24 May 2019 15:52:48 +0200 Subject: [PATCH 1/2] Make compatible with torch >= 0.5 --- Models/webaskb_ptrnet.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Models/webaskb_ptrnet.py b/Models/webaskb_ptrnet.py index 5e179cb..4a5012e 100644 --- a/Models/webaskb_ptrnet.py +++ b/Models/webaskb_ptrnet.py @@ -225,7 +225,7 @@ def forward(self,input_variable, target_variable, loss=0, DO_TECHER_FORCING=Fals result.append(np.argmax(decoder_attention.data[0].tolist())) if type(loss)!=int: - loss_value = loss.data[0] / target_length + loss_value = loss.item() / target_length else: loss_value = 0 - return loss_value , result, loss \ No newline at end of file + return loss_value , result, loss From b8f4488ce9a226bca0f0cff278cc84fd7d2d1f6c Mon Sep 17 00:00:00 2001 From: Clara Meister Date: Fri, 24 May 2019 15:58:55 +0200 Subject: [PATCH 2/2] Removing .py extension since using module flag https://docs.python.org/3/using/cmdline.html --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f1746d0..ffd6bce 100755 --- a/README.md +++ b/README.md @@ -72,11 +72,11 @@ can be downloaded from [ComplexWebQuestions](http://nlp.cs.tau.ac.il/compwebq) Now you can do any of the following: -* Generate the noisy supervision data for training `python -m webaskb_run.py gen_noisy_sup`. -* Run a pointer network to generate split points in the question `python -m webaskb_run.py run_ptrnet`. -* Train the pointer network `python -m webaskb_run.py train_ptrnet`. -* Create final predication and calculate p@1 scores `python -m webaskb_run.py splitqa`. -* NEW! Run evaluation script for dev set `python -m eval_script.py Data/complex_web_questions/ComplexWebQuestions_dev.json Data/predictions_dev.json`. +* Generate the noisy supervision data for training `python -m webaskb_run gen_noisy_sup`. +* Run a pointer network to generate split points in the question `python -m webaskb_run run_ptrnet`. +* Train the pointer network `python -m webaskb_run train_ptrnet`. +* Create final predication and calculate p@1 scores `python -m webaskb_run splitqa`. +* NEW! Run evaluation script for dev set `python -m eval_script Data/complex_web_questions/ComplexWebQuestions_dev.json Data/predictions_dev.json`. Options: ‘—eval_set dev’ or ‘—eval_set test’ to choose between the development and test set.