Leaderboard: dbasunag/opendatahub-tests (69.9/100 - Silver)#301
Merged
kami619 merged 1 commit intoambient-code:mainfrom Feb 19, 2026
Conversation
Score: 69.9/100 (Silver) Repository: https://github.com/dbasunag/opendatahub-tests
Contributor
📈 Test Coverage Report
Coverage calculated from unit tests only |
Collaborator
Collaborator
|
@jeremyeder WDYT is the best path forward here ? |
Contributor
|
we want the most impactful checks, the number 25 isn't special. if we find only 10 really matter then that is success |
Contributor
Author
|
I ran the command like this None of these are relevant for a downstream test repository. |
kami619
pushed a commit
to kami619/agentready
that referenced
this pull request
Feb 19, 2026
Relaxes the JSON schema constraints to accept assessments with 10-25 attributes instead of exactly 25. This enables users who run `agentready assess --exclude` to submit valid assessments to the leaderboard. Changes: - `attributes_total`: changed from `const: 25` to `minimum: 10, maximum: 25` - `findings`: changed from `minItems: 25, maxItems: 25` to `minItems: 10, maxItems: 25` Added regression tests to verify: - Assessments with 10 attributes validate (minimum boundary) - Assessments with 22 attributes validate (PR ambient-code#301 case) - Assessments with fewer than 10 attributes are rejected Fixes ambient-code#309
19 tasks
Contributor
|
🎉 This PR is included in version 2.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Feb 23, 2026
kami619
added a commit
that referenced
this pull request
Feb 23, 2026
PR #301 submitted an assessment for dbasunag's fork instead of the official opendatahub-io/opendatahub-tests repository. The correct submission was made in PR #314. This removes the incorrect submission to avoid duplicate/confusing entries in the leaderboard. Co-authored-by: Ambient Code Bot <bot@ambient-code.local> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
kami619
added a commit
that referenced
this pull request
Feb 24, 2026
* fix(schema): allow assessments with excluded attributes Relaxes the JSON schema constraints to accept assessments with 10-25 attributes instead of exactly 25. This enables users who run `agentready assess --exclude` to submit valid assessments to the leaderboard. Changes: - `attributes_total`: changed from `const: 25` to `minimum: 10, maximum: 25` - `findings`: changed from `minItems: 25, maxItems: 25` to `minItems: 10, maxItems: 25` Added regression tests to verify: - Assessments with 10 attributes validate (minimum boundary) - Assessments with 22 attributes validate (PR #301 case) - Assessments with fewer than 10 attributes are rejected Fixes #309 * fix(schema): add cross-field validation to validate-report Add programmatic cross-field validation to SchemaValidator.validate_report() to enforce constraints that JSON Schema draft-07 cannot express: - len(findings) == attributes_total - attributes_assessed + attributes_skipped == attributes_total These constraints are documented in specs/001-agentready-scorer/data-model.md but were only enforced internally by the Assessment model. External reports submitted via validate-report bypassed this validation. Addresses PR #312 review comment about cross-field consistency. Fixes #309 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Ambient Code Bot <bot@ambient-code.local> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaderboard Submission
Repository: dbasunag/opendatahub-tests
Score: 69.9/100
Tier: Silver
Submitted by: @dbasunag
Validation Checklist
Automated validation will run on this PR.
Submitted via
agentready submitcommand.