Make get_validated_url_file_path function compatible with non-static files

[aristath]

In some cases and projects we need to dynamically generate CSS.
If the URL is domain.com/?action=my-theme-get-styles&foo=bar and not a static file like domain.com/something.css then the validation fails due to the missing file extension and the CSS never gets parsed by AMP

[westonruter]

Humm. I thought this would work now. See #1317 and #1357

What is the validation error? What is the full markup?

[aristath]

The error:

The URL it tries to get is http://localhost?action=kirki-styles
the markup:

<link rel='stylesheet' id='kirki-styles-css'  href='http://localhost?action=kirki-styles' type='text/css' media='all' />

[aristath]

perhaps it's because I'm on localhost (no TLD)?

[westonruter]

I don't think that should matter. From the condition here:

amp-wp/includes/sanitizers/class-amp-style-sanitizer.php

Lines 717 to 718 in d0f36c9

	if ( is_wp_error( $css_file_path ) && ( 'disallowed_file_extension' === $css_file_path->get_error_code() || 'external_file_url' === $css_file_path->get_error_code() ) ) {
	$contents = $this->fetch_external_stylesheet( $normalized_url );

It seems like that should be just what you need. Because it is a disallowed_file_extension error, it should then fall through to treat it like it is fetching an external stylesheet. The fetch_external_stylesheet method should really be named fetch_stylesheet_over_http.

[westonruter]

@aristath I've opened a PR with some changes which I think will fix what you're seeing here. Please give the build linked here a try: #1852 (comment)

[aristath]

Confirmed, that PR fixes the issue 👍