meson: wip: headerchecks cpluspluschecks

Author: anarazel

src/include/meson.build

@@ -44,9 +44,9 @@ config_paths_data.set_quoted('MANDIR', dir_prefix / dir_man)
 
 var_cc = ' '.join(cc.cmd_array())
 var_cpp = ' '.join(cc.cmd_array() + ['-E'])
-var_cflags = ' '.join(cflags + cflags_warn + get_option('c_args'))
+var_cflags = ' '.join(cflags + cflags_warn + get_option('c_args') + ['-Wall'])
 if llvm.found()
-  var_cxxflags = ' '.join(cxxflags + cxxflags_warn + get_option('cpp_args'))
+  var_cxxflags = ' '.join(cxxflags + cxxflags_warn + get_option('cpp_args') + ['-Wall'])
 else
   var_cxxflags = ''
 endif

src/include/utils/pg_locale.h

@@ -16,6 +16,8 @@
 #include <xlocale.h>
 #endif
 #ifdef USE_ICU
+/* the cplusplus portion doesn't parse inside extern "C" { } */
+#define U_SHOW_CPLUSPLUS_API 0
 #include <unicode/ucol.h>
 #endif
 

src/meson.build

@@ -51,3 +51,20 @@ install_data(
 install_data(
   'makefiles/pgxs.mk',
   install_dir: dir_pgxs / 'src' / 'makefiles')
+
+
+generated_sources_stamp = custom_target('generated-sources-stamp.h',
+  output: 'generated-sources-stamp.h',
+  input: [generated_sources, generated_headers_stamp, generated_backend_headers_stamp],
+  command: stamp_cmd,
+)
+
+run_target('headerscheck',
+  command: [files('tools/pginclude/headerscheck'), '@SOURCE_ROOT@', '@BUILD_ROOT@'],
+  depends: [generated_sources_stamp, generated_headers_stamp, generated_backend_headers_stamp],
+)
+
+run_target('cpluspluscheck',
+  command: [files('tools/pginclude/cpluspluscheck'), '@SOURCE_ROOT@', '@BUILD_ROOT@'],
+  depends: [generated_sources_stamp, generated_headers_stamp, generated_backend_headers_stamp],
+)

src/tools/pginclude/cpluspluscheck

@@ -198,7 +198,7 @@ do
 	    src/pl/plperl/*)
 		EXTRAINCLUDES="$perl_includespec" ;;
 	    src/pl/plpython/*)
-		EXTRAINCLUDES="$python_includespec" ;;
+		EXTRAINCLUDES="$python_includespec"; ;;
 	    src/interfaces/ecpg/*)
 		EXTRAINCLUDES="-I $builddir/src/interfaces/ecpg/include -I $srcdir/src/interfaces/ecpg/include" ;;
 	    src/backend/parser/*)