From e476e863b3b15fda746be93043af20b9322eb844 Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:22:20 +0900 Subject: [PATCH 1/7] Test on iOS 17 Beta --- .github/workflows/ci.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 758b14e..4ff7544 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,3 +38,13 @@ jobs: - uses: actions/checkout@v3 - name: Test run: make test + + test-on-ios-beta: + name: Test on iOS Beta + runs-on: macos-13 + env: + DEVELOPER_DIR: /Applications/Xcode_15.0.app/Contents/Developer + steps: + - uses: actions/checkout@v3 + - name: Test + run: xcodebuild test -scheme swift-atproto-Package -destination "OS=17.0" From 50dad4abf3aa485548b650d86ba34000e810e74d Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:26:53 +0900 Subject: [PATCH 2/7] Specify platform --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4ff7544..dff7f2a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,4 +47,7 @@ jobs: steps: - uses: actions/checkout@v3 - name: Test - run: xcodebuild test -scheme swift-atproto-Package -destination "OS=17.0" + run: | + xcodebuild test \ + -scheme swift-atproto-Package \ + -destination "platform=iOS Simulator,OS=17.0" From e5e0c40610972729a87b61075af92d6a929d54e0 Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:27:05 +0900 Subject: [PATCH 3/7] Use xcpretty --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dff7f2a..6c72981 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,4 +50,4 @@ jobs: run: | xcodebuild test \ -scheme swift-atproto-Package \ - -destination "platform=iOS Simulator,OS=17.0" + -destination "platform=iOS Simulator,OS=17.0" | xcpretty From 24b82fb5132cc5ebf975394d7b97eac5f98727d8 Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:35:00 +0900 Subject: [PATCH 4/7] [tmp] Failure test case on iOS 17 --- Tests/ATProtoXRPCTests/TemporaryTests.swift | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 Tests/ATProtoXRPCTests/TemporaryTests.swift diff --git a/Tests/ATProtoXRPCTests/TemporaryTests.swift b/Tests/ATProtoXRPCTests/TemporaryTests.swift new file mode 100644 index 0000000..3463344 --- /dev/null +++ b/Tests/ATProtoXRPCTests/TemporaryTests.swift @@ -0,0 +1,9 @@ +import Foundation +import XCTest + +final class TemporaryTests: XCTestCase { + func testExample() throws { + let data = #""at://did:plc:z72i7hdynmk6r22z27h6tvur/app.bsky.feed.generator/whats-hot""#.data(using: .utf8)! + XCTAssertNoThrow(try JSONDecoder().decode(URL.self, from: data)) + } +} From 15579bbc55eaf88358098006da913492bb96071f Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:40:35 +0900 Subject: [PATCH 5/7] Fix to use xcodebuild exit code --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6c72981..92ddb56 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,4 +50,4 @@ jobs: run: | xcodebuild test \ -scheme swift-atproto-Package \ - -destination "platform=iOS Simulator,OS=17.0" | xcpretty + -destination "platform=iOS Simulator,OS=17.0" | xcpretty && exit ${PIPESTATUS[0]} From b7a2717cded84f32b030a0dd9ab21cf6edab5cb2 Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:43:47 +0900 Subject: [PATCH 6/7] Not to use xcpretty --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92ddb56..dff7f2a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,4 +50,4 @@ jobs: run: | xcodebuild test \ -scheme swift-atproto-Package \ - -destination "platform=iOS Simulator,OS=17.0" | xcpretty && exit ${PIPESTATUS[0]} + -destination "platform=iOS Simulator,OS=17.0" From ba68a789f378e3b3ee47f443cd1c64cb55e41593 Mon Sep 17 00:00:00 2001 From: andooown Date: Wed, 13 Sep 2023 22:47:33 +0900 Subject: [PATCH 7/7] Revert "[tmp] Failure test case on iOS 17" This reverts commit 24b82fb5132cc5ebf975394d7b97eac5f98727d8. --- Tests/ATProtoXRPCTests/TemporaryTests.swift | 9 --------- 1 file changed, 9 deletions(-) delete mode 100644 Tests/ATProtoXRPCTests/TemporaryTests.swift diff --git a/Tests/ATProtoXRPCTests/TemporaryTests.swift b/Tests/ATProtoXRPCTests/TemporaryTests.swift deleted file mode 100644 index 3463344..0000000 --- a/Tests/ATProtoXRPCTests/TemporaryTests.swift +++ /dev/null @@ -1,9 +0,0 @@ -import Foundation -import XCTest - -final class TemporaryTests: XCTestCase { - func testExample() throws { - let data = #""at://did:plc:z72i7hdynmk6r22z27h6tvur/app.bsky.feed.generator/whats-hot""#.data(using: .utf8)! - XCTAssertNoThrow(try JSONDecoder().decode(URL.self, from: data)) - } -}