Skip to content

getUpcomingNewMoon() and getUpcomingFullMoon() are often incorrect when close to the event #75

@willem-syt

Description

@willem-syt

Hi,
First of all, thank you for this great library.

I did notice that when you calculate e.g. New Moon for 2024-01-15 12:00:00 (UTC) the result will be in the past (i.e. 2024-01-11 11:58:48).
Similarly a Full Moon calculation for 2024-01-24 12:00:00 gives 2024-02-24 12:31:24 (it should be 2024-01-25 17:55:01):

2024-01-15 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-16 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-17 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-18 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-19 12:00:00 Full Moon 2024-01-25 17:55:01
2024-01-20 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-21 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-22 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-23 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-24 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-25 12:00:00 Full Moon 2024-02-24 12:31:24
2024-01-26 12:00:00 Full Moon 2024-02-24 12:31:24

At this moment I check the results and re-calculate with a different date if needed.

Next to that it would be nice to add the Age (in days) for the Moon (i.e. 0 at New Moon and ~14.7 at Full Moon). At the moment I calculate this by determining the previous New Moon event and subtracting it from the ToI.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions