Skip to content

General Feedback, #77

@saturdaywalkers

Description

@saturdaywalkers

Thanks for all the work!

suggest documenting "toi date" => "js date", couldn't find it in the doco, but could in the code ( toi.getDate() )

(for the moon)

getIlluminatedFraction(), isWaxing(), getPhaseAngle() all work on a date-time,
but getRise/Transit/Set() only work on a date, i.e. the hours/minutes/seconds of an input 'toi' date get ignored?

If that is correct should state it more obviously

(for the moon)

getPhaseAngle() only returns 0-180, not 0-360 ?
am i using the wrong call ?
(needed a 0-360 angle to create an SVG image showing the shape of the moon), this seems what i needed
( 180 + ( isWaxing ? ( 380 - getPhaseAngle ) : getPhaseAngle ) ) % 360 )

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions