From 5bda0c823b1336455f54f560ae8c468edef94b7e Mon Sep 17 00:00:00 2001 From: James Morgan Date: Tue, 29 Mar 2016 23:02:10 +0100 Subject: [PATCH 1/2] Comp delete() --- .gitignore | 4 +--- api/Competition.js | 19 ++++++++++++++++++- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 0838445..ad44592 100644 --- a/.gitignore +++ b/.gitignore @@ -1,10 +1,8 @@ node_modules .idea/* -<<<<<<< Updated upstream reactable.iml npm-debug.log -======= ->>>>>>> Stashed changes ./public/js/bundle.js startApp.sh public/js/bundle.js +.DS_Store diff --git a/api/Competition.js b/api/Competition.js index 446d4ea..9e10d95 100644 --- a/api/Competition.js +++ b/api/Competition.js @@ -28,6 +28,23 @@ var competitionRoutes = function (app, Competition) { }); + app.delete('/competition/:competitionId', function (req, res) { + console.log('DELETE /competition/' + req.params.competitionId); + + //TODO check admin user + + Competition + .find({'_id': req.params.competitionId}) + .remove() + .exec() + .then(function (comp) { + res.send(comp); + }, function (error) { + console.log('Ooops: ' + error); + res.status(500).send('Ooops: Unable to retrieve data!'); + }); + }); + app.post('/auth/competition', function (req, res) { console.log('POST /admin/create/competition'); @@ -36,7 +53,7 @@ var competitionRoutes = function (app, Competition) { Competition.create(req.body, function (err, competition) { if (err) { - res.send(err); + res.status(500).send(err); // TODO handle validation/schema errors vs app errors? } else { res.send(competition); } From e40c4856c6858844f0ce90e8f884f9bb90f8d328 Mon Sep 17 00:00:00 2001 From: James Morgan Date: Tue, 29 Mar 2016 23:05:06 +0100 Subject: [PATCH 2/2] Respond with id --- api/Competition.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/Competition.js b/api/Competition.js index 9e10d95..c5b8054 100644 --- a/api/Competition.js +++ b/api/Competition.js @@ -37,8 +37,8 @@ var competitionRoutes = function (app, Competition) { .find({'_id': req.params.competitionId}) .remove() .exec() - .then(function (comp) { - res.send(comp); + .then(function () { + res.send({'_id': req.params.competitionId}); }, function (error) { console.log('Ooops: ' + error); res.status(500).send('Ooops: Unable to retrieve data!');