Skip to content

Commit e56392e

Browse files
committed
Display quick fix even when error region has a length equal to 0.
1 parent c976de3 commit e56392e

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/ui/hover/AbstractAnnotationHover.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public Object getHoverInfo2(ITextViewer textViewer, IRegion hoverRegion) {
139139
Iterator<Annotation> parent;
140140
if (model instanceof IAnnotationModelExtension2)
141141
parent = ((IAnnotationModelExtension2) model).getAnnotationIterator(hoverRegion.getOffset(),
142-
hoverRegion.getLength(), true, true);
142+
hoverRegion.getLength() > 0 ? hoverRegion.getLength() : 1, true, true);
143143
else
144144
parent = model.getAnnotationIterator();
145145
Iterator<Annotation> e = new TypeScriptAnnotationIterator(parent, fAllAnnotations);
@@ -192,22 +192,25 @@ public Object getHoverInfo2(ITextViewer textViewer, IRegion hoverRegion) {
192192
protected AnnotationInfo createAnnotationInfo(Annotation annotation, Position position, ITextViewer textViewer) {
193193
return new AnnotationInfo(annotation, position, textViewer);
194194
}
195-
195+
196196
@Override
197197
public IInformationControlCreator getHoverControlCreator() {
198198
if (fHoverControlCreator == null)
199-
fHoverControlCreator= new HoverControlCreator(getInformationPresenterControlCreator());
199+
fHoverControlCreator = new HoverControlCreator(getInformationPresenterControlCreator());
200200
return fHoverControlCreator;
201201
}
202202

203203
/*
204-
* @see org.eclipse.jdt.internal.ui.text.java.hover.AbstractJavaEditorTextHover#getInformationPresenterControlCreator()
204+
* @see
205+
* org.eclipse.jdt.internal.ui.text.java.hover.AbstractJavaEditorTextHover#
206+
* getInformationPresenterControlCreator()
207+
*
205208
* @since 3.4
206209
*/
207210
@Override
208211
public IInformationControlCreator getInformationPresenterControlCreator() {
209212
if (fPresenterControlCreator == null)
210-
fPresenterControlCreator= new PresenterControlCreator();
213+
fPresenterControlCreator = new PresenterControlCreator();
211214
return fPresenterControlCreator;
212215
}
213216

@@ -558,7 +561,8 @@ private void createCompletionProposalsControl(Composite parent, ICompletionPropo
558561
if (proposals.length == 1) {
559562
text = TypeScriptUIMessages.AbstractAnnotationHover_message_singleQuickFix;
560563
} else {
561-
text = NLS.bind(TypeScriptUIMessages.AbstractAnnotationHover_message_multipleQuickFix, new Object[] { String.valueOf(proposals.length) });
564+
text = NLS.bind(TypeScriptUIMessages.AbstractAnnotationHover_message_multipleQuickFix,
565+
new Object[] { String.valueOf(proposals.length) });
562566
}
563567
quickFixLabel.setText(text);
564568

0 commit comments

Comments
 (0)