Skip to content
This repository was archived by the owner on May 25, 2019. It is now read-only.

Commit 5b83552

Browse files
committed
Added initalization of undefined $viewValue when value is a range
When using a range the $viewValue is now initialized as an array with 0 as default values.
1 parent 512c571 commit 5b83552

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/slider.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,17 @@ angular.module('ui.slider', []).value('uiSliderConfig',{}).directive('uiSlider',
8282
ngModel.$render = function() {
8383
init();
8484
var method = options.range === true ? 'values' : 'value';
85-
86-
if (!options.range && isNaN(ngModel.$viewValue) && !(ngModel.$viewValue instanceof Array))
85+
86+
if (!options.range && isNaN(ngModel.$viewValue) && !(ngModel.$viewValue instanceof Array)) {
8787
ngModel.$viewValue = 0;
88+
}
89+
else if (options.range && !angular.isDefined(ngModel.$viewValue)) {
90+
ngModel.$viewValue = [0,0];
91+
}
8892

8993
// Do some sanity check of range values
9094
if (options.range === true) {
91-
95+
9296
// Check outer bounds for min and max values
9397
if (angular.isDefined(options.min) && options.min > ngModel.$viewValue[0]) {
9498
ngModel.$viewValue[0] = options.min;
@@ -98,7 +102,7 @@ angular.module('ui.slider', []).value('uiSliderConfig',{}).directive('uiSlider',
98102
}
99103

100104
// Check min and max range values
101-
if (ngModel.$viewValue[0] >= ngModel.$viewValue[1]) {
105+
if (ngModel.$viewValue[0] > ngModel.$viewValue[1]) {
102106
// Min value should be less to equal to max value
103107
if (prevRangeValues.min >= ngModel.$viewValue[1])
104108
ngModel.$viewValue[0] = prevRangeValues.min;

0 commit comments

Comments
 (0)