Skip to content
This repository was archived by the owner on May 25, 2019. It is now read-only.

Commit 923f5e9

Browse files
committed
Merge pull request #57 from pan100/JSHint
JSHint gave warnings
2 parents a29725e + a33728d commit 923f5e9

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/slider.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ angular.module('ui.slider', []).value('uiSliderConfig',{}).directive('uiSlider',
99
return function (scope, elm, attrs, ngModel) {
1010

1111
function parseNumber(n, decimals) {
12-
return (decimals) ? parseFloat(n) : parseInt(n);
13-
};
12+
return (decimals) ? parseFloat(n) : parseInt(n, 10);
13+
}
1414

1515
var options = angular.extend(scope.$eval(attrs.uiSlider) || {}, uiSliderConfig);
1616
// Object holding range values
@@ -64,7 +64,7 @@ angular.module('ui.slider', []).value('uiSliderConfig',{}).directive('uiSlider',
6464
// Watch ui-slider (byVal) for changes and update
6565
scope.$watch(attrs.uiSlider, function(newVal) {
6666
init();
67-
if(newVal != undefined) {
67+
if(newVal !== undefined) {
6868
elm.slider('option', newVal);
6969
}
7070
}, true);
@@ -104,11 +104,13 @@ angular.module('ui.slider', []).value('uiSliderConfig',{}).directive('uiSlider',
104104
// Check min and max range values
105105
if (ngModel.$viewValue[0] > ngModel.$viewValue[1]) {
106106
// Min value should be less to equal to max value
107-
if (prevRangeValues.min >= ngModel.$viewValue[1])
107+
if (prevRangeValues.min >= ngModel.$viewValue[1]) {
108108
ngModel.$viewValue[0] = prevRangeValues.min;
109+
}
109110
// Max value should be less to equal to min value
110-
if (prevRangeValues.max <= ngModel.$viewValue[0])
111+
if (prevRangeValues.max <= ngModel.$viewValue[0]) {
111112
ngModel.$viewValue[1] = prevRangeValues.max;
113+
}
112114
}
113115

114116
// Store values for later user

0 commit comments

Comments
 (0)