-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Open
Open
Enhancement
Copy link
Labels
area: @angular-devkit/corefeatureIssue that requests a new featureIssue that requests a new featurefeature: in backlogFeature request for which voting has completed and is now in the backlogFeature request for which voting has completed and is now in the backlog
Milestone
Description
🚀 Feature request
Command (mark with an x
)
- generate
Description
The templating for the @angular/devkit library uses EJS, sort of but doesn't support whitespace slurping the way that the documentation of EJS has declared it. Having this would enable schematic templates to be much more flexible with their whitespace and therefor easier to read while still creating nicely formatted files.
Describe the solution you'd like
The three delimiters: "<%_"
, "_%>"
and "-%>"
should just be added and work the same way that they do in EJS.
I already have an idea of the code that I'd like to add, and a pull request almost ready. It's very simple and only affects one file.
Examples
Within @schematics/angular this would allow an example like the following
import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
<%_ if (routing) { %>
import { AppRoutingModule } from './app-routing.module';
<%_ } -%>
import { AppComponent } from './app.component';
@NgModule({
declarations: [
AppComponent
],
imports: [
<%_ if (routing) { -%>
AppRoutingModule,
<%_ } -%>
BrowserModule
],
providers: [],
bootstrap: [AppComponent]
})
export class AppModule { }
Which would generate with the correct whitespace.
andresjosehr, stephenlautier, field123, Alex88360 and szirmi
Metadata
Metadata
Assignees
Labels
area: @angular-devkit/corefeatureIssue that requests a new featureIssue that requests a new featurefeature: in backlogFeature request for which voting has completed and is now in the backlogFeature request for which voting has completed and is now in the backlog