From 4186d3ed56e24f16ec4dff259a0e6fe38f1ff014 Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Tue, 22 Jul 2025 15:13:24 +0000 Subject: [PATCH] fix(@angular-devkit/build-angular): expand `jest` and `jest-environment-jsdom` to allow version 30 This commit expands the peer deps of these dependencies to allow version 30. Closes #30760 --- packages/angular_devkit/build_angular/package.json | 4 ++-- tests/legacy-cli/e2e/tests/jest/basic-version-29.ts | 13 +++++++++++++ tests/legacy-cli/e2e/utils/jest.ts | 2 +- 3 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 tests/legacy-cli/e2e/tests/jest/basic-version-29.ts diff --git a/packages/angular_devkit/build_angular/package.json b/packages/angular_devkit/build_angular/package.json index a2eedc8229d7..0e278a95e2af 100644 --- a/packages/angular_devkit/build_angular/package.json +++ b/packages/angular_devkit/build_angular/package.json @@ -81,8 +81,8 @@ "@angular/ssr": "^0.0.0-PLACEHOLDER", "@web/test-runner": "^0.20.0", "browser-sync": "^3.0.2", - "jest": "^29.5.0", - "jest-environment-jsdom": "^29.5.0", + "jest": "^29.5.0 || ^30.0.5", + "jest-environment-jsdom": "^29.5.0 || ^30.0.5", "karma": "^6.3.0", "ng-packagr": "0.0.0-NG-PACKAGR-PEER-DEP", "protractor": "^7.0.0", diff --git a/tests/legacy-cli/e2e/tests/jest/basic-version-29.ts b/tests/legacy-cli/e2e/tests/jest/basic-version-29.ts new file mode 100644 index 000000000000..a83e1dd5d795 --- /dev/null +++ b/tests/legacy-cli/e2e/tests/jest/basic-version-29.ts @@ -0,0 +1,13 @@ +import { applyJestBuilder } from '../../utils/jest'; +import { ng, silentNpm } from '../../utils/process'; + +export default async function (): Promise { + await applyJestBuilder(); + await silentNpm('install', 'jest@29.5.0', 'jest-environment-jsdom@29.5.0', '--save-dev'); + + const { stderr } = await ng('test'); + + if (!stderr.includes('Jest builder is currently EXPERIMENTAL')) { + throw new Error(`No experimental notice in stderr.\nSTDERR:\n\n${stderr}`); + } +} diff --git a/tests/legacy-cli/e2e/utils/jest.ts b/tests/legacy-cli/e2e/utils/jest.ts index 904cc6f903d6..517470ed7c4d 100644 --- a/tests/legacy-cli/e2e/utils/jest.ts +++ b/tests/legacy-cli/e2e/utils/jest.ts @@ -8,7 +8,7 @@ export async function applyJestBuilder( polyfills: ['zone.js', 'zone.js/testing'], }, ): Promise { - await silentNpm('install', 'jest@29.5.0', 'jest-environment-jsdom@29.5.0', '--save-dev'); + await silentNpm('install', 'jest@30.0.5', 'jest-environment-jsdom@30.0.5', '--save-dev'); await updateJsonFile('angular.json', (json) => { const projects = Object.values(json['projects']);