Your operators were bad and you should feel bad

Author: jamesdaniels

src/performance/performance.ts

@@ -73,18 +73,18 @@ export class AngularFirePerformance {
     })
   );
 
-  traceUntil = <T=any>(name:string, test: (a:T) => boolean, options?: TraceOptions & { orComplete: boolean }) => (source$: Observable<T>) => {
+  traceUntil = <T=any>(name:string, test: (a:T) => boolean, options?: TraceOptions & { orComplete: boolean }) => (source$: Observable<T>) => new Observable<T>(subscriber => {
     const traceSubscription = this.trace$(name, options).subscribe();
     return source$.pipe(
       tap(
         a  => test(a) && traceSubscription.unsubscribe(),
         () => {},
         () => options && options.orComplete && traceSubscription.unsubscribe()
       )
-    )
-  };
+    ).subscribe(subscriber);
+  });
 
-  traceWhile = <T=any>(name:string, test: (a:T) => boolean, options?: TraceOptions & { orComplete: boolean}) => (source$: Observable<T>) => {
+  traceWhile = <T=any>(name:string, test: (a:T) => boolean, options?: TraceOptions & { orComplete: boolean}) => (source$: Observable<T>) => new Observable<T>(subscriber => {
     let traceSubscription: Subscription|undefined;
     return source$.pipe(
       tap(
@@ -99,40 +99,40 @@ export class AngularFirePerformance {
         () => {},
         () => options && options.orComplete && traceSubscription && traceSubscription.unsubscribe()
       )
-    )
-  };
+    ).subscribe(subscriber);
+  });
 
-  traceUntilComplete = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => {
+  traceUntilComplete = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => new Observable<T>(subscriber => {
     const traceSubscription = this.trace$(name, options).subscribe();
     return source$.pipe(
       tap(
         () => {},
         () => {},
         () => traceSubscription.unsubscribe()
       )
-    )
-  };
+    ).subscribe(subscriber);
+  });
 
-  traceUntilFirst = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => {
+  traceUntilFirst = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => new Observable<T>(subscriber => {
     const traceSubscription = this.trace$(name, options).subscribe();
     return source$.pipe(
       tap(
         () => traceSubscription.unsubscribe(),
         () => {},
         () => {}
       )
-    )
-  };
+    ).subscribe(subscriber);
+  });
 
-  trace = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => {
+  trace = <T=any>(name:string, options?: TraceOptions) => (source$: Observable<T>) => new Observable<T>(subscriber => {
     const traceSubscription = this.trace$(name, options).subscribe();
     return source$.pipe(
       tap(
         () => traceSubscription.unsubscribe(),
         () => {},
         () => traceSubscription.unsubscribe()
       )
-    )
-  };
+    ).subscribe(subscriber);
+  });
 
 }