Skip to content

Commit 651d75a

Browse files
committed
refactor to use ButterKnife
1 parent 88ad166 commit 651d75a

File tree

3 files changed

+13
-22
lines changed

3 files changed

+13
-22
lines changed

app/src/main/java/com/anotherdev/sample/firebase/auth/ChangePasswordDialog.java

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,18 @@
44
import android.view.View;
55
import android.widget.EditText;
66

7+
import butterknife.BindView;
8+
79
@SuppressWarnings("WeakerAccess")
810
public class ChangePasswordDialog extends MultipleTextInputDialog {
911

1012
public interface OnConfirmClickListener {
1113
void onConfirmClick(String oldPassword, String newPassword);
1214
}
1315

14-
private EditText currentPasswordEditText;
15-
private EditText newPasswordEditText;
16-
private EditText verifyPasswordEditText;
16+
@BindView(R.id.old_password_edittext) EditText currentPasswordEditText;
17+
@BindView(R.id.new_password_edittext) EditText newPasswordEditText;
18+
@BindView(R.id.verify_password_edittext) EditText verifyPasswordEditText;
1719

1820
private OnConfirmClickListener confirmClickListener;
1921

@@ -30,14 +32,6 @@ protected int getLayoutRes() {
3032
return R.layout.view_change_password_input;
3133
}
3234

33-
@Override
34-
protected void onConfigureView(View view) {
35-
super.onConfigureView(view);
36-
currentPasswordEditText = view.findViewById(R.id.old_password_edittext);
37-
newPasswordEditText = view.findViewById(R.id.new_password_edittext);
38-
verifyPasswordEditText = view.findViewById(R.id.verify_password_edittext);
39-
}
40-
4135
@Override
4236
public ChangePasswordDialog setListener(int viewId, boolean dismissOnClick, View.OnClickListener listener) {
4337
super.setListener(viewId, dismissOnClick, listener);

app/src/main/java/com/anotherdev/sample/firebase/auth/EmailPasswordDialog.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
import com.anotherdev.firebase.auth.SignInResponse;
88

9+
import butterknife.BindView;
910
import io.reactivex.rxjava3.core.Single;
1011

1112
@SuppressWarnings("WeakerAccess")
@@ -15,8 +16,8 @@ public interface OnConfirmClickListener {
1516
Single<SignInResponse> onConfirmClick(String email, String password);
1617
}
1718

18-
private EditText emailEditText;
19-
private EditText passwordEditText;
19+
@BindView(R.id.email_edittext) EditText emailEditText;
20+
@BindView(R.id.password_edittext) EditText passwordEditText;
2021

2122
private OnConfirmClickListener confirmClickListener;
2223

@@ -31,13 +32,6 @@ protected int getLayoutRes() {
3132
return R.layout.view_email_password_input;
3233
}
3334

34-
@Override
35-
protected void onConfigureView(View view) {
36-
super.onConfigureView(view);
37-
emailEditText = view.findViewById(R.id.email_edittext);
38-
passwordEditText = view.findViewById(R.id.password_edittext);
39-
}
40-
4135
@Override
4236
public EmailPasswordDialog setListener(int viewId, boolean dismissOnClick, View.OnClickListener listener) {
4337
super.setListener(viewId, dismissOnClick, listener);

app/src/main/java/com/anotherdev/sample/firebase/auth/MultipleTextInputDialog.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,12 @@
1010

1111
import com.yarolegovich.lovelydialog.LovelyCustomDialog;
1212

13+
import butterknife.BindView;
14+
import butterknife.ButterKnife;
15+
1316
abstract class MultipleTextInputDialog extends LovelyCustomDialog {
1417

15-
private TextView positiveButton;
18+
@BindView(R.id.positive_button) TextView positiveButton;
1619

1720

1821
MultipleTextInputDialog(Context context) {
@@ -28,7 +31,7 @@ abstract class MultipleTextInputDialog extends LovelyCustomDialog {
2831

2932
@CallSuper
3033
protected void onConfigureView(View view) {
31-
positiveButton = view.findViewById(R.id.positive_button);
34+
ButterKnife.bind(this, view);
3235
}
3336

3437
@CallSuper

0 commit comments

Comments
 (0)