Skip to content

Commit 5b4f425

Browse files
authored
Merge pull request #764 from webknjaz/revert/maintenance/gha-exclude-py312-plus-with-sdist
Revert "🧪 Drop GHA jobs w/ sdist install @ Python 3.12+"
2 parents a6af2a2 + 66a555c commit 5b4f425

File tree

3 files changed

+4
-28
lines changed

3 files changed

+4
-28
lines changed

.github/workflows/ci-cd.yml

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,18 +1246,6 @@ jobs:
12461246
dist-type:
12471247
- binary
12481248
- source
1249-
exclude:
1250-
# NOTE: Python 3.12+ with installs from sdist hits a bug in tox
1251-
# NOTE: which makes it fail until GHA times out. This is why the
1252-
# NOTE: following exclusions are in place. They should be
1253-
# NOTE: removed once tox fixes said bug.
1254-
# Ref: https://github.com/tox-dev/tox/issues/3512
1255-
- python-version: 3.14
1256-
dist-type: source
1257-
- python-version: 3.13
1258-
dist-type: source
1259-
- python-version: 3.12
1260-
dist-type: source
12611249

12621250
uses: ./.github/workflows/reusable-tests.yml
12631251
with:
@@ -1293,18 +1281,6 @@ jobs:
12931281
dist-type:
12941282
- binary
12951283
- source
1296-
exclude:
1297-
# NOTE: Python 3.12+ with installs from sdist hits a bug in tox
1298-
# NOTE: which makes it fail until GHA times out. This is why the
1299-
# NOTE: following exclusions are in place. They should be
1300-
# NOTE: removed once tox fixes said bug.
1301-
# Ref: https://github.com/tox-dev/tox/issues/3512
1302-
- python-version: 3.14
1303-
dist-type: source
1304-
- python-version: 3.13
1305-
dist-type: source
1306-
- python-version: 3.12
1307-
dist-type: source
13081284

13091285
uses: ./.github/workflows/reusable-tests.yml
13101286
with:
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
The ``requires`` setting has been removed from :file:`tox.ini`, which
2+
works around the upstream tool bug. This enabled us to re-introduce
3+
CI jobs testing against sdist under Python 3.12 and newer
4+
-- by :user:`webknjaz`.

tox.ini

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
[tox]
22
envlist = python
33
minversion = 3.21.0
4-
requires =
5-
setuptools >= 40.9.0
6-
pip >= 19.0.3
7-
# tox-venv >= 0.4.0
84
isolated_build = true
95

106

0 commit comments

Comments
 (0)