From bffa20b675abebf8ed8616d59ba07f6692f284ab Mon Sep 17 00:00:00 2001 From: Eduardo Blanco Date: Fri, 10 Oct 2025 11:26:42 +0200 Subject: [PATCH 1/6] Fixed design type --- src/ansys/aedt/core/extensions/common/points_cloud.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ansys/aedt/core/extensions/common/points_cloud.py b/src/ansys/aedt/core/extensions/common/points_cloud.py index 22135ddf73e..44e3df8170a 100644 --- a/src/ansys/aedt/core/extensions/common/points_cloud.py +++ b/src/ansys/aedt/core/extensions/common/points_cloud.py @@ -86,11 +86,11 @@ def __init__(self, withdraw: bool = False): self.add_extension_content() def check_design_type(self): - """Check if the design type is HFSS, Icepak, HFSS 3D, Maxwell 3D, Q3D, Mechanical""" - if self.aedt_application.design_type not in ["HFSS", "Icepak", "HFSS 3D", "Maxwell 3D", "Q3D", "Mechanical"]: + """Check if the design type is HFSS, Icepak, HFSS 3D, Maxwell 3D, Maxwell 2D, Q3D, Mechanical""" + if self.aedt_application.design_type not in ["HFSS", "Icepak", "HFSS 3D", "Maxwell 3D", "Maxwell 2D", "Q3D", "Mechanical"]: self.release_desktop() raise AEDTRuntimeError( - "This extension only works with HFSS, Icepak, HFSS 3D, Maxwell 3D, Q3D, or Mechanical designs." + "This extension only works with HFSS, Icepak, HFSS 3D, Maxwell 3D, Maxwell 2D, Q3D, or Mechanical designs." ) def __load_aedt_info(self): From 2ee3d41b813e75e3a1ce497423d0b200df1ba732 Mon Sep 17 00:00:00 2001 From: Eduardo Blanco Date: Fri, 10 Oct 2025 14:53:37 +0200 Subject: [PATCH 2/6] FIX: Update points cloud extension call --- .../aedt/core/extensions/maxwell3d/fields_distribution.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py b/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py index 1d37fdd0bc8..f882ce6e239 100644 --- a/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py +++ b/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py @@ -289,13 +289,14 @@ def show_points_popup(): def submit(): if option_var.get() == "Option 1": - from ansys.aedt.core.extensions.common.points_cloud import main as points_main + from ansys.aedt.core.extensions.common.points_cloud import PointsCloudExtensionData, main as points_main selected_objects = self._widgets["objects_list_lb"].curselection() objects_list = [self._widgets["objects_list_lb"].get(i) for i in selected_objects] points = points_entry.get("1.0", tkinter.END).strip() try: - pts_path = points_main({"is_test": False, "choice": objects_list, "points": int(points)}) + data = PointsCloudExtensionData(choice=objects_list, points=int(points)) + pts_path = points_main(data) self._text_size(pts_path, self._widgets["sample_points_entry"]) except Exception as e: messagebox.showerror("Error", f"Failed to generate points: {str(e)}") From c6f19430e30083bfa60b7d9395da7682f2be52dc Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 10 Oct 2025 13:06:37 +0000 Subject: [PATCH 3/6] CHORE: Auto fixes from pre-commit hooks --- src/ansys/aedt/core/extensions/common/points_cloud.py | 10 +++++++++- .../core/extensions/maxwell3d/fields_distribution.py | 3 ++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/ansys/aedt/core/extensions/common/points_cloud.py b/src/ansys/aedt/core/extensions/common/points_cloud.py index 44e3df8170a..4cf7d3c1f1f 100644 --- a/src/ansys/aedt/core/extensions/common/points_cloud.py +++ b/src/ansys/aedt/core/extensions/common/points_cloud.py @@ -87,7 +87,15 @@ def __init__(self, withdraw: bool = False): def check_design_type(self): """Check if the design type is HFSS, Icepak, HFSS 3D, Maxwell 3D, Maxwell 2D, Q3D, Mechanical""" - if self.aedt_application.design_type not in ["HFSS", "Icepak", "HFSS 3D", "Maxwell 3D", "Maxwell 2D", "Q3D", "Mechanical"]: + if self.aedt_application.design_type not in [ + "HFSS", + "Icepak", + "HFSS 3D", + "Maxwell 3D", + "Maxwell 2D", + "Q3D", + "Mechanical", + ]: self.release_desktop() raise AEDTRuntimeError( "This extension only works with HFSS, Icepak, HFSS 3D, Maxwell 3D, Maxwell 2D, Q3D, or Mechanical designs." diff --git a/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py b/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py index f882ce6e239..d8041f413a6 100644 --- a/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py +++ b/src/ansys/aedt/core/extensions/maxwell3d/fields_distribution.py @@ -289,7 +289,8 @@ def show_points_popup(): def submit(): if option_var.get() == "Option 1": - from ansys.aedt.core.extensions.common.points_cloud import PointsCloudExtensionData, main as points_main + from ansys.aedt.core.extensions.common.points_cloud import PointsCloudExtensionData + from ansys.aedt.core.extensions.common.points_cloud import main as points_main selected_objects = self._widgets["objects_list_lb"].curselection() objects_list = [self._widgets["objects_list_lb"].get(i) for i in selected_objects] From 1413259fb26c5600b943a52cd1676a58e48b316b Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Fri, 10 Oct 2025 13:09:38 +0000 Subject: [PATCH 4/6] chore: adding changelog file 6750.fixed.md [dependabot-skip] --- doc/changelog.d/6750.fixed.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/6750.fixed.md diff --git a/doc/changelog.d/6750.fixed.md b/doc/changelog.d/6750.fixed.md new file mode 100644 index 00000000000..7bdc11ac939 --- /dev/null +++ b/doc/changelog.d/6750.fixed.md @@ -0,0 +1 @@ +Design type check and update points cloud extension call From 449ad0e50a43bbfb78019f08babb08464b091178 Mon Sep 17 00:00:00 2001 From: Eduardo Blanco Date: Fri, 10 Oct 2025 15:26:40 +0200 Subject: [PATCH 5/6] Fixed line too long issue --- src/ansys/aedt/core/extensions/common/points_cloud.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/extensions/common/points_cloud.py b/src/ansys/aedt/core/extensions/common/points_cloud.py index 44e3df8170a..b85ad9d4903 100644 --- a/src/ansys/aedt/core/extensions/common/points_cloud.py +++ b/src/ansys/aedt/core/extensions/common/points_cloud.py @@ -90,7 +90,8 @@ def check_design_type(self): if self.aedt_application.design_type not in ["HFSS", "Icepak", "HFSS 3D", "Maxwell 3D", "Maxwell 2D", "Q3D", "Mechanical"]: self.release_desktop() raise AEDTRuntimeError( - "This extension only works with HFSS, Icepak, HFSS 3D, Maxwell 3D, Maxwell 2D, Q3D, or Mechanical designs." + "This extension only works with HFSS, Icepak, HFSS 3D, " \ + "Maxwell 3D, Maxwell 2D, Q3D, or Mechanical designs." ) def __load_aedt_info(self): From 208d608b2ad97ad698886f269665f5e83ad08724 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 10 Oct 2025 13:27:28 +0000 Subject: [PATCH 6/6] CHORE: Auto fixes from pre-commit hooks --- src/ansys/aedt/core/extensions/common/points_cloud.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/extensions/common/points_cloud.py b/src/ansys/aedt/core/extensions/common/points_cloud.py index af83740d004..18ae1d578ce 100644 --- a/src/ansys/aedt/core/extensions/common/points_cloud.py +++ b/src/ansys/aedt/core/extensions/common/points_cloud.py @@ -98,7 +98,7 @@ def check_design_type(self): ]: self.release_desktop() raise AEDTRuntimeError( - "This extension only works with HFSS, Icepak, HFSS 3D, " \ + "This extension only works with HFSS, Icepak, HFSS 3D, " "Maxwell 3D, Maxwell 2D, Q3D, or Mechanical designs." )