Companion timeout exception not caught?

[caizixian]

subprocess.TimeoutExpired: Command '['/home/claireh/mmtk-core/tools/tracing/performance/run.py', '-b', '/opt/bpftrace/bpftrace-static', '-m', '/home/claireh/openjdk/build/mmtk/images/jdk/lib/server/libmmtk_openjdk.so', '-f', 'json', '--harness', 'packet_size']' timed out after 10 seconds

The try ... except ... should have caught it.

running-ng/src/running/benchmark.py

Line 157 in 53b4be6

"Companion program not exited after 10 seconds timeout. Trying to kill ..."

Reported by @clairexhuang . She might follow up with more details.

[clairexhuang]

Context: running a tracing command with an outdated/broken harness so the companion failed to exit. Tried to reproduce and it did print
avrora 3000 24 0[WARNING] 2024-10-01 05:10:12,797 benchmark.py:156 Companion program not exited after 10 seconds timeout. Trying to kill ...
as expected. Suspect I may have just missed it the first time around, and the first exception was printed when killing the script.

I think it would be helpful for debugging to have a slightly more descriptive warning though. e.g. "Companion program failed to exit and communicate within 10 seconds of the main program ending. Please ensure it has a termination mechanism."