diff --git a/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java b/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java index fd54934ade6..e322f5cbd26 100644 --- a/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java +++ b/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java @@ -41,7 +41,6 @@ import static org.apache.accumulo.core.util.LazySingletons.RANDOM; import static org.apache.accumulo.core.util.Validators.EXISTING_TABLE_NAME; import static org.apache.accumulo.core.util.Validators.NEW_TABLE_NAME; -import static org.apache.accumulo.core.util.Validators.NOT_BUILTIN_TABLE; import static org.apache.accumulo.core.util.threads.ThreadPoolNames.SPLIT_START_POOL; import static org.apache.accumulo.core.util.threads.ThreadPoolNames.SPLIT_WAIT_POOL; @@ -223,8 +222,7 @@ public SortedSet list() { public boolean exists(String tableName) { EXISTING_TABLE_NAME.validate(tableName); - if (tableName.equals(SystemTables.METADATA.tableName()) - || tableName.equals(SystemTables.ROOT.tableName())) { + if (SystemTables.containsTableName(tableName)) { return true; } @@ -1511,15 +1509,13 @@ private void changeTableState(String tableName, boolean wait, TableState newStat switch (newState) { case OFFLINE: op = TFateOperation.TABLE_OFFLINE; - if (tableName.equals(SystemTables.METADATA.tableName()) - || tableName.equals(SystemTables.ROOT.tableName())) { + if (SystemTables.containsTableName(tableName)) { throw new AccumuloException("Cannot set table to offline state"); } break; case ONLINE: op = TFateOperation.TABLE_ONLINE; - if (tableName.equals(SystemTables.METADATA.tableName()) - || tableName.equals(SystemTables.ROOT.tableName())) { + if (SystemTables.containsTableName(tableName)) { // Don't submit a Fate operation for this, these tables can only be online. return; } @@ -2243,7 +2239,10 @@ private void validatePropertiesToSet(Map opts, Map public void setTabletAvailability(String tableName, Range range, TabletAvailability availability) throws AccumuloSecurityException, AccumuloException { EXISTING_TABLE_NAME.validate(tableName); - NOT_BUILTIN_TABLE.validate(tableName); + if (SystemTables.containsTableName(tableName)) { + throw new AccumuloException("Cannot set set tablet availability for table " + tableName); + } + checkArgument(range != null, "range is null"); checkArgument(availability != null, "tabletAvailability is null"); diff --git a/server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java b/server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java index dd9788e85b6..61cedce94c5 100644 --- a/server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java +++ b/server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java @@ -27,7 +27,6 @@ import static org.apache.accumulo.core.util.Validators.NOT_BUILTIN_NAMESPACE; import static org.apache.accumulo.core.util.Validators.NOT_BUILTIN_TABLE; import static org.apache.accumulo.core.util.Validators.NOT_BUILTIN_TABLE_ID; -import static org.apache.accumulo.core.util.Validators.NOT_METADATA_TABLE; import static org.apache.accumulo.core.util.Validators.NOT_ROOT_TABLE_ID; import static org.apache.accumulo.core.util.Validators.VALID_TABLE_ID; import static org.apache.accumulo.core.util.Validators.sameNamespaceAs; @@ -692,7 +691,8 @@ public void executeFateOperation(TInfo tinfo, TCredentials c, TFateId opid, TFat case TABLE_TABLET_AVAILABILITY: { TableOperation tableOp = TableOperation.SET_TABLET_AVAILABILITY; validateArgumentCount(arguments, tableOp, 3); - String tableName = validateName(arguments.get(0), tableOp, NOT_METADATA_TABLE); + String tableName = + validateName(arguments.get(0), tableOp, NOT_BUILTIN_TABLE.and(EXISTING_TABLE_NAME)); TableId tableId = null; try { tableId = manager.getContext().getTableId(tableName);