Skip to content

Add conditional support for GIT_SYNC_USERNAME/GIT_SYNC_PASSWORD vs GITSYNC_USERNAME/GITSYNC_PASSWORD in Helm Chart #52320

Open
@kyungjunleeme

Description

@kyungjunleeme

See also: #43247. While not directly related, this issue shares a similar context.

Description

Problem

Currently, the Airflow Helm Chart expects Git Sync v4-style secrets (GITSYNC_USERNAME, GITSYNC_PASSWORD) regardless of the actual version of the Git Sync image used.

However, when using Git Sync v3 (e.g., dags.gitSync.image.tag: v3.6.9), the expected environment variables are:

  • GIT_SYNC_USERNAME
  • GIT_SYNC_PASSWORD

But the chart only renders the v4-style variables (GITSYNC_*), which results in errors or broken Git sync behavior for v3 users.

Proposal

Add logic in _helpers.yaml (or related templates) to:

  • Detect Git Sync version via dags.gitSync.image.tag
  • If v3: render
    - name: GIT_SYNC_USERNAME
      ...
    - name: GIT_SYNC_PASSWORD
      ...
    
    

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

Metadata

Metadata

Assignees

Labels

area:helm-chartAirflow Helm Chartkind:featureFeature Requestsneeds-triagelabel for new issues that we didn't triage yet

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions