From 9b81662c42faabde4bc9907417a4c41423111499 Mon Sep 17 00:00:00 2001 From: houxiaoyu Date: Sun, 4 Feb 2024 23:12:01 +0800 Subject: [PATCH 1/2] Change log level to error when ReadEntryProcessor IOException --- .../java/org/apache/bookkeeper/proto/ReadEntryProcessor.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java index d321623c54b..db3a4595cb7 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java @@ -105,9 +105,7 @@ protected void processPacket() { } errorCode = BookieProtocol.ENOENTRY; } catch (IOException e) { - if (LOG.isDebugEnabled()) { - LOG.debug("Error reading {}", request, e); - } + LOG.error("Error reading {}", request, e); errorCode = BookieProtocol.EIO; } catch (BookieException.DataUnknownException e) { LOG.error("Ledger {} is in an unknown state", request.getLedgerId(), e); From 0eaf8ab9867a3a44917d6e67d2ca5cfc2561f006 Mon Sep 17 00:00:00 2001 From: houxiaoyu Date: Sun, 4 Feb 2024 23:23:28 +0800 Subject: [PATCH 2/2] Optimize --- .../java/org/apache/bookkeeper/proto/ReadEntryProcessor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java index db3a4595cb7..805de54d68d 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java @@ -105,7 +105,7 @@ protected void processPacket() { } errorCode = BookieProtocol.ENOENTRY; } catch (IOException e) { - LOG.error("Error reading {}", request, e); + LOG.error("IOException while reading {}", request, e); errorCode = BookieProtocol.EIO; } catch (BookieException.DataUnknownException e) { LOG.error("Ledger {} is in an unknown state", request.getLedgerId(), e);