Add test for check permissions after authorize #4502
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac1d0globlya
reviewed
Dec 1, 2025
|
|
||
| executeNet(String.format("CREATE ROLE %s WITH LOGIN = TRUE AND password='%s'", user, pass)); | ||
|
|
||
| final String idm_user = "idm_user"; |
There was a problem hiding this comment.
Let's rename idm_user to "simple_user"
ac1d0globlya
reviewed
Dec 1, 2025
| useUser(idm_user, idm_user); | ||
| assertUnauthorizedQuery("User idm_user has no SELECT permission on <table check_permissions.t1> or any of its parents", | ||
| "SELECT * FROM check_permissions.t1"); | ||
| assertUnauthorizedQuery("User idm_user has no SELECT permission on <table check_permissions.t1> or any of its parents", |
There was a problem hiding this comment.
Let's check that after this exception user "user" still has no select permission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no test covering this case: a user must have more than just the AUTHORIZE permission to grant permissions to others.
patch by Valery Baranov klammrock@gmail.com