Skip to content

Commit 7eb7c0a

Browse files
committed
exception-message
1 parent 56d7ba8 commit 7eb7c0a

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import javax.inject.Inject;
3535
import javax.naming.ConfigurationException;
3636

37+
import com.cloud.user.*;
3738
import org.apache.cloudstack.acl.SecurityChecker.AccessType;
3839
import org.apache.cloudstack.api.ApiConstants;
3940
import org.apache.cloudstack.api.BaseCmd;
@@ -184,12 +185,6 @@
184185
import com.cloud.storage.dao.VolumeDao;
185186
import com.cloud.template.TemplateAdapter.TemplateAdapterType;
186187
import com.cloud.template.VirtualMachineTemplate.BootloaderType;
187-
import com.cloud.user.Account;
188-
import com.cloud.user.AccountManager;
189-
import com.cloud.user.AccountService;
190-
import com.cloud.user.AccountVO;
191-
import com.cloud.user.ResourceLimitService;
192-
import com.cloud.user.UserData;
193188
import com.cloud.user.dao.AccountDao;
194189
import com.cloud.uservm.UserVm;
195190
import com.cloud.utils.DateUtil;
@@ -1448,6 +1443,7 @@ public boolean updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissions
14481443
// Input validation
14491444
final Long id = cmd.getId();
14501445
final Account caller = CallContext.current().getCallingAccount();
1446+
final User user = CallContext.current().getCallingUser();
14511447
List<String> accountNames = cmd.getAccountNames();
14521448
List<Long> projectIds = cmd.getProjectIds();
14531449
Boolean isFeatured = cmd.isFeatured();
@@ -1517,9 +1513,9 @@ public boolean updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissions
15171513
}
15181514

15191515
if (owner.getType() == Account.Type.PROJECT) {
1520-
// Currently project owned templates cannot be shared outside project but is available to all users within project by default.
1521-
throw new InvalidParameterValueException("Update template permissions is an invalid operation on template " + template.getName() +
1522-
". Project owned templates cannot be shared outside template.");
1516+
_accountMgr.checkAccess(user, template);
1517+
// throw new InvalidParameterValueException("Update template permissions is an invalid operation on template " + template.getName() +
1518+
// ". Project owned templates cannot be shared outside the project.");
15231519
}
15241520

15251521
// check configuration parameter(allow.public.user.templates) value for

0 commit comments

Comments
 (0)