Unable to deploy VM using Template and custom disk offering

[sbrueseke]

ISSUE TYPE

• Bug Report

COMPONENT NAME

VM

CLOUDSTACK VERSION

4.17.2.0

CONFIGURATION

hypervisor: xcp-ng, advanced networking

OS / ENVIRONMENT

SUMMARY

Unable to deploy VM using Template and custom disk offering, fails with error "VM Creation failed. Volume size: -1GB is out of allowed range. Max: 1024 Min:1". This issue is similar to this issue which for ISO: #6440 but not the same.

STEPS TO REPRODUCE

1. Add a new Disk Offering with customized = true
   /client/api/?isMirrored=false&name=Test+Custom+Disk+Offering&displaytext=Test+Custom+Disk+Offering&storageType=shared&cacheMode=none&provisioningType=thin&customized=true&disksizestrictness=false&command=createDiskOffering&response=json

2. Create a new Compute Offering with diskofferingstrictness=true (please be aware that in 4.17.2.0 there is a bug and you cannot do this via UI. There is a button for this, but it is broken. This has already being fixed UI: fix diskofferingstrictness is not passed when create compute offering #7072) You need to add the disk offering uuid in this api call!
   /client/api/?issystem=false&name=Test+Compute+Offering&displaytext=Test+Compute+Offering&customized=false&offerha=false&limitcpuuse=false&dynamicscalingenabled=false&diskofferingid=<uuid>&cpunumber=1&cpuspeed=500&memory=512&command=createServiceOffering&diskofferingstrictness=true&response=json

3. Go to the instance wizard in the UI and choose the just created Compute offering. Do not click anything else and go straight to “Launch instance”.

EXPECTED RESULTS

UI needs to pass parameter rootdisksize with a default value in header of api call deployVirtualMachine even if "Override root disk size" in Template/ISO section is disabled. I do not know where do get this default value from.

ACTUAL RESULTS

UI is not passing parameter rootdisksize via header when using api call deployVirtualMachine and "Override root disk size" in Template/ISO section is disabled. When enabling "Override root disk size" in Template/ISO section a default value of 10 is inserted into the wizard and it works.

[sbrueseke]

A question in my opinion is if a custom disk offering should have a default or minimum size value attached to it. I am not sure where the value of 10 is coming from, but I suppose from the used template parameters.

[weizhouapache]

@sbrueseke
I can reproduce the issue on UI.

The default value of root disk size comes from the virtual size (not physical size) of vm template. see example below

(localcloud) 🐱 > list templates templatefilter=all filter=size,physicalsize
{
  "count": 4,
  "template": [
    {
      "physicalsize": 461307904,
      "size": 5242880000
    },
    {
      "physicalsize": 43646976,
      "size": 52428800
    },
    {
      "physicalsize": 453181440,
      "size": 4194304000
    },
    {
      "physicalsize": 1769537536,
      "size": 8589934592
    }
  ]
}

[sbrueseke]

@weizhouapache does it make sense to add the default template size to the api call if another value is not provided?

[weizhouapache]

@sbrueseke yes, it makes sense.
I think it should be obliged to set the root disk size when disk offering is dynamic and strictness is true.

a UI bug

[sbrueseke]

@weizhouapache yes, it should be, but which is the default value to put into the wizard? The size of the template?

[weizhouapache]

@weizhouapache yes, it should be, but which is the default value to put into the wizard? The size of the template?

yes @sbrueseke
If vm is created from ISO, the default might be 1

[weizhouapache]

fyi, the workaround is as below

check "Override root disk size" , then it works