From 66dcd5294b355de70af6758388737af527f7016e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=83=82=E6=B3=A5=E6=89=B6=E4=B8=8A=E5=A2=99?= <2114486405@qq.com> Date: Wed, 21 Jan 2026 22:03:44 +0800 Subject: [PATCH 1/3] Fix ClassNotFoundException message variable --- src/main/java/org/apache/commons/lang3/ClassUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/lang3/ClassUtils.java b/src/main/java/org/apache/commons/lang3/ClassUtils.java index b4bfd4d22b0..5c2cf099d19 100644 --- a/src/main/java/org/apache/commons/lang3/ClassUtils.java +++ b/src/main/java/org/apache/commons/lang3/ClassUtils.java @@ -601,7 +601,7 @@ public static Class getClass(final ClassLoader classLoader, final String clas } } } while (lastDotIndex != -1); - throw new ClassNotFoundException(next); + throw new ClassNotFoundException(className); } /** From 9b88ac9034bec92534407954822cc2226d0ed3c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=83=82=E6=B3=A5=E6=89=B6=E4=B8=8A=E5=A2=99?= <2114486405@qq.com> Date: Thu, 22 Jan 2026 21:53:37 +0800 Subject: [PATCH 2/3] Improve exception assertion in ClassUtilsTest Update exception handling in assertGetClassThrowsException method to capture and verify exception messages. --- src/test/java/org/apache/commons/lang3/ClassUtilsTest.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java index 9029bb1e363..bdeeb517797 100644 --- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java @@ -110,8 +110,11 @@ private void assertGetClassThrowsClassNotFound(final String className) { } private void assertGetClassThrowsException(final String className, final Class exceptionType) { - assertThrows(exceptionType, () -> ClassUtils.getClass(className), + final Exception exception = assertThrows(exceptionType, () -> ClassUtils.getClass(className), "ClassUtils.getClass() should fail with an exception of type " + exceptionType.getName() + " when given class name \"" + className + "\"."); + if (className != null) { + assertEquals(className, exception.getMessage()); + } } private void assertGetClassThrowsNullPointerException(final String className) { @@ -1251,6 +1254,7 @@ void testGetClassClassNotFound() throws Exception { assertGetClassThrowsClassNotFound("bool"); assertGetClassThrowsClassNotFound("bool[]"); assertGetClassThrowsClassNotFound("integer[]"); + assertGetClassThrowsClassNotFound("org.apache.commons.lang3.ClassUtilsTest.AClassThatCannotBeFound"); } @Test From 410cc21385b6b076f5bb2490a26b50f1665a654c Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Thu, 22 Jan 2026 10:30:30 -0500 Subject: [PATCH 3/3] Fix indentation. --- .../java/org/apache/commons/lang3/ClassUtilsTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java index bdeeb517797..abe8004e425 100644 --- a/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java +++ b/src/test/java/org/apache/commons/lang3/ClassUtilsTest.java @@ -110,11 +110,11 @@ private void assertGetClassThrowsClassNotFound(final String className) { } private void assertGetClassThrowsException(final String className, final Class exceptionType) { - final Exception exception = assertThrows(exceptionType, () -> ClassUtils.getClass(className), + final Exception exception = assertThrows(exceptionType, () -> ClassUtils.getClass(className), "ClassUtils.getClass() should fail with an exception of type " + exceptionType.getName() + " when given class name \"" + className + "\"."); - if (className != null) { - assertEquals(className, exception.getMessage()); - } + if (className != null) { + assertEquals(className, exception.getMessage()); + } } private void assertGetClassThrowsNullPointerException(final String className) {