Skip to content

Commit ce1b5af

Browse files
committed
FELIX-6774 org.apache.felix.http.jetty.maxFormSize not enforced
- Fix test; when calling getParameter("key"), an IOException is thrown (leading to a HTTP 500). This is as expected
1 parent b7030c6 commit ce1b5af

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

http/jetty12/src/test/java/org/apache/felix/http/jetty/it/JettyMaxFormSizeIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,16 +114,16 @@ public void testFormSizeLimit() throws Exception {
114114
formFieldsLimitExceeded.add(new Fields.Field("key", "valueoverlimit")); // over limit of 10 bytes
115115
ContentResponse responseExceeded = httpClient.FORM(uri, formFieldsLimitExceeded);
116116

117-
// TODO why does this need yield a HTTP 413?
118-
// Seems maxFormSize is not enforced?
119-
assertEquals(413, responseExceeded.getStatus());
117+
// HTTP 500 thrown, because req.getParameter("key") throws an IOEx
118+
assertEquals(500, responseExceeded.getStatus());
120119

121120
httpClient.close();
122121
}
123122

124123
static final class HelloWorldServlet extends HttpServlet {
125124
@Override
126125
protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
126+
req.getParameter("key"); // this triggers the maxFormSize check
127127
resp.setStatus(200);
128128
resp.getWriter().write("OK");
129129
}

0 commit comments

Comments
 (0)