[Feature][runtime] Support the use of Python ChatModel in Java #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatEugenius
changed the title
GreatEugenius
changed the title
Collaborator
Author
|
@Sxnan @wenjin272 please help take a look this PR, thanks. |
GreatEugenius
changed the title
GreatEugenius
added
priority/major
wenjin272
reviewed
Nov 14, 2025
Collaborator
wenjin272
left a comment
wenjin272
left a comment
There was a problem hiding this comment.
Hi, @GreatEugenius, thanks for your work. Overall looks good to me . I left some comments about details.
Besides, I think this pr should add some test cases to show how to declare an agent in java using python chat model, and verify the behavior.
plan/src/main/java/org/apache/flink/agents/plan/resourceprovider/PythonResourceProvider.java
Outdated
Show resolved
Hide resolved
plan/src/main/java/org/apache/flink/agents/plan/resourceprovider/PythonResourceProvider.java
Outdated
Show resolved
Hide resolved
plan/src/test/resources/resource_providers/python_resource_provider.json
Outdated
Show resolved
Hide resolved
plan/src/main/java/org/apache/flink/agents/plan/resourceprovider/PythonResourceProvider.java
Show resolved
Hide resolved
.../src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonDeserializer.java
Outdated
Show resolved
Hide resolved
Sxnan
reviewed
Nov 14, 2025
Contributor
Sxnan
left a comment
Sxnan
left a comment
There was a problem hiding this comment.
Thanks for the PR. However, the PR lacks tests. For such a complex feature, we need to have unit tests and e2e tests.
api/src/main/java/org/apache/flink/agents/api/prompt/Prompt.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/chat/model/python/PythonChatModelConnection.java
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/resource/python/PythonResourceAdapter.java
Outdated
Show resolved
Hide resolved
GreatEugenius
force-pushed
the
python-chatmodel-in-java
branch
2 times, most recently
from
44f5690 to
e6c063f
Compare
Collaborator
Author
|
Hi @Sxnan and @wenjin272, thank you for the review! I have updated this PR and added a PythonChatModel example for the end-to-end test. Please take a look. Thanks! |
wenjin272
reviewed
Nov 18, 2025
plan/src/main/java/org/apache/flink/agents/plan/resourceprovider/PythonResourceProvider.java
Outdated
Show resolved
Hide resolved
Sxnan
reviewed
Nov 18, 2025
...on-test/src/main/java/org/apache/flink/agents/integration/test/AgentWithPythonChatModel.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/flink/agents/api/prompt/Prompt.java
Outdated
Show resolved
Hide resolved
GreatEugenius
force-pushed
the
python-chatmodel-in-java
branch
2 times, most recently
from
afb3b60 to
57b88dc
Compare
Collaborator
Author
|
Hi @Sxnan, thank you for the review! I have updated this PR; please review it again. |
GreatEugenius
force-pushed
the
python-chatmodel-in-java
branch
4 times, most recently
from
d19b8c3 to
8bc4c9c
Compare
GreatEugenius
force-pushed
the
python-chatmodel-in-java
branch
2 times, most recently
from
99d1407 to
a1b6fe2
Compare
GreatEugenius
force-pushed
the
python-chatmodel-in-java
branch
from
a1b6fe2 to
92dbb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #313
Purpose of change
Support the use of Python ChatModel in Java Flink Agents jobs.
Tests
ut
API
no
Documentation
doc-neededdoc-not-needed