[Feature][Java] Add OpenAI chat model integration #320
+740
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
priority/major
|
@xli1996 Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-needed
wenjin272
reviewed
Nov 20, 2025
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Outdated
Show resolved
Hide resolved
lihaosky
reviewed
Nov 20, 2025
|
|
||
| Map<String, Object> paramSchema = getParamSchema(param); | ||
| paramSchema.put("description", paramDescription); | ||
| if (paramDescription != null) { |
Collaborator
There was a problem hiding this comment.
How can this be null? Looks getParamSchema at least returns Map<String, Object> paramSchema = new HashMap<>();
Author
There was a problem hiding this comment.
I hit the issue when my Tool annotation has no description, seems it just skip
if (!toolParam.description().isEmpty()) {
paramDescription = toolParam.description();
}
and stay null, maybe we can just remove if (!toolParam.description().isEmpty()) {
Author
|
@wenjin272 @lihaosky Thanks for the review, can you take another look, I have addressed some comments. |
wenjin272
reviewed
Nov 24, 2025
...n/java/org/apache/flink/agents/integrations/chatmodels/openai/OpenAIChatModelConnection.java
Show resolved
Hide resolved
Collaborator
|
LGTM. Please take a look at your convenience @xintongsong |
Contributor
|
@xli1996
|
# Conflicts: # e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/AgentWithOpenAI.java # e2e-test/flink-agents-end-to-end-tests-integration/src/test/java/org/apache/flink/agents/integration/test/AgentWithOpenAIExample.java
Author
|
@xintongsong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #319
Purpose of change
This PR adds support for the Open AI chat model as a foundational model.
Tests
Added one IT test, also tried manually with ReactAgentExample but replace Ollama model with OpenAI one.
API
No
Documentation
doc-neededYes, will update docs once this get merged.