Skip to content

[hotfix] Fix the type loss issue in the deserialization of ResourceProvider #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[hotfix] Fix the type loss issue in the deserialization of ResourceProvider #343

wants to merge 1 commit into from
+5 −5

Conversation

@GreatEugenius
Copy link
Collaborator

@GreatEugenius GreatEugenius commented Nov 27, 2025 •
edited
Loading

Purpose of change

Fix the type loss issue in the deserialization of ResourceProvider and correct the improper use of the descriptor.

Tests

ut

API

Documentation

The commit already includes the changes to the Docs.

  • doc-needed
  • doc-not-needed

@github-actions github-actions bot added priority/major Default priority of the PR or issue. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. doc-not-needed Your PR changes do not impact docs labels Nov 27, 2025
@GreatEugenius
Copy link
Collaborator Author

GreatEugenius commented Nov 27, 2025

Hi, @Sxnan and @wenjin272, please take a look at this PR. Thank you.

@GreatEugenius GreatEugenius changed the title [hotfix] Fix the type loss issue in agent plan deserialization [hotfix] Fix the type loss issue in the deserialization of ResourceProvider Nov 27, 2025
@wenjin272
Copy link
Collaborator

wenjin272 commented Nov 27, 2025

What result will the type loss cause?

@GreatEugenius
Copy link
Collaborator Author

GreatEugenius commented Nov 27, 2025 •
edited
Loading

What result will the type loss cause?

Currently, it does not affect user usage because a forced type conversion has been performed on the Python side through the BaseModel. However, to support cross-language features, we need to address this issue first.

@wenjin272
Copy link
Collaborator

wenjin272 commented Nov 28, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenjin272 wenjin272 Awaiting requested review from wenjin272

@Sxnan Sxnan Awaiting requested review from Sxnan

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GreatEugenius @wenjin272