Skip to content

[hotfix] Fix the type loss issue in the deserialization of ResourceProvider #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

[hotfix] Fix the type loss issue in the deserialization of ResourceProvider #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/docs/development/workflow_agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public class ReviewAnalysisAgent extends Agent {
.addInitialArgument("model", "qwen3:8b")
.addInitialArgument("prompt", "reviewAnalysisPrompt")
.addInitialArgument("tools", Collections.singletonList("notifyShippingManager"))
.addInitialArgument("extract_reasoning", "true")
.addInitialArgument("extract_reasoning", true)
.build();
}

Expand Down
2 changes: 1 addition & 1 deletion examples/src/main/java/org/apache/flink/agents/examples/agents/ReviewAnalysisAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public static ResourceDescriptor reviewAnalysisModel() {
.addInitialArgument("model", "qwen3:8b")
.addInitialArgument("prompt", "reviewAnalysisPrompt")
.addInitialArgument("tools", Collections.singletonList("notifyShippingManager"))
.addInitialArgument("extract_reasoning", "true")
.addInitialArgument("extract_reasoning", true)
.build();
}

Expand Down
2 changes: 1 addition & 1 deletion ...ain/java/org/apache/flink/agents/integrations/chatmodels/ollama/OllamaChatModelSetup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public OllamaChatModelSetup(
ResourceDescriptor descriptor, BiFunction<String, ResourceType, Resource> getResource) {
super(descriptor, getResource);
this.model = descriptor.getArgument("model");
this.extractReasoning = Boolean.parseBoolean(descriptor.getArgument("extract_reasoning"));
this.extractReasoning = descriptor.getArgument("extract_reasoning");
}

/**
Expand Down
4 changes: 2 additions & 2 deletions ...c/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ private PythonResourceProvider deserializePythonResourceProvider(JsonNode node)
JsonNode kwargsNode = node.get("kwargs");
Map<String, Object> kwargs = new HashMap<>();
if (kwargsNode != null && kwargsNode.isObject()) {
kwargs = (Map<String, Object>) parseJsonNode(kwargsNode);
kwargs = mapper.convertValue(kwargsNode, Map.class);
}
return new PythonResourceProvider(
name, ResourceType.fromValue(type), module, clazz, kwargs);
Expand All @@ -98,7 +98,7 @@ private PythonSerializableResourceProvider deserializePythonSerializableResource
JsonNode serializedNode = node.get("serialized");
Map<String, Object> serialized = new HashMap<>();
if (serializedNode != null && serializedNode.isObject()) {
serialized = (Map<String, Object>) parseJsonNode(serializedNode);
serialized = mapper.convertValue(serializedNode, Map.class);
}
return new PythonSerializableResourceProvider(
name, ResourceType.fromValue(type), module, clazz, serialized);
Expand Down