From f5a124beef6b65bf8f9178120fefc1360566fda6 Mon Sep 17 00:00:00 2001 From: Dionysios Logothetis Date: Tue, 19 Sep 2017 07:47:56 -0700 Subject: [PATCH 1/2] Fix bug in memory estimation --- .../java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java | 1 - 1 file changed, 1 deletion(-) diff --git a/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java b/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java index 1233183e6..7146f4ca2 100644 --- a/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java +++ b/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java @@ -792,7 +792,6 @@ private static boolean calculateRegression(double[] coefficient, LOG.warn("There are " + coefficient.length + " coefficients, but " + validColumnIndices.size() + " valid columns in the regression"); - return false; } double[] beta = mlr.estimateRegressionParameters(); From 8e06d2b9b5c0192e57ffbbfd93336ef6829eaeec Mon Sep 17 00:00:00 2001 From: Dionysios Logothetis Date: Wed, 20 Sep 2017 12:37:46 -0700 Subject: [PATCH 2/2] Change log line --- .../org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java b/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java index 7146f4ca2..73f6681f8 100644 --- a/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java +++ b/giraph-core/src/main/java/org/apache/giraph/ooc/policy/MemoryEstimatorOracle.java @@ -789,8 +789,8 @@ private static boolean calculateRegression(double[] coefficient, List validColumnIndices, OLSMultipleLinearRegression mlr) { if (coefficient.length != validColumnIndices.size()) { - LOG.warn("There are " + coefficient.length + - " coefficients, but " + validColumnIndices.size() + + LOG.info("There are " + coefficient.length + + " coefficients, and " + validColumnIndices.size() + " valid columns in the regression"); }