Commit 12c4c21
authored
feat(reader): null struct default values in create_column (#1847)
Fixes
`TestSparkReaderDeletes.testPosDeletesOnParquetFileWithMultipleRowGroups`
in Iceberg Java 1.10 with DataFusion Comet.
## Which issue does this PR close?
- Partially address #1749.
## What changes are included in this PR?
- While `RecordBatchTransformer` does not have exhaustive nested type
support yet, this adds logic to `create_column` in the specific scenario
for a schema evolution with a new struct column that uses the default
NULL value.
- If the column has a default value other than NULL defined, it will
fall into the existing match arm and say it is unsupported.
## Are these changes tested?
New test to reflect what happens with Iceberg Java 1.10's
`TestSparkReaderDeletes.testPosDeletesOnParquetFileWithMultipleRowGroups`.
The test is misleading, since I figured testing positional deletes would
just be a delete vector and be schema agnostic, but [it includes schema
change with binary and struct types so we need default NULL
values](https://github.com/apache/iceberg/blob/53c046efda5d6c6ac67caf7de29849ab7ac6d406/data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java#L65).1 parent 8d4851f commit 12c4c21
1 file changed
+93
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
594 | 596 | | |
595 | 597 | | |
596 | 598 | | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
597 | 614 | | |
598 | 615 | | |
599 | 616 | | |
| |||
743 | 760 | | |
744 | 761 | | |
745 | 762 | | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
746 | 839 | | |
747 | 840 | | |
748 | 841 | | |
| |||
0 commit comments