fix 0.5.x release cargo publish (#1379)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Closes #.

## What changes are included in this PR?

<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
This PR removes `iceberg-catalog-memory` as a dev-dependency of
`crates/iceberg`. The dependency is not used and caused `cargo publish`
to fail during the 0.5.0 release (See
#1325 (comment))

This PR also changes `.github/workflows/release_python.yml` to depend on
`publish.yml` since we only want to publish `pyiceberg-core` to pypi
after the crates are successfully published.


https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow

## Are these changes tested?

<!--
Specify what test covers (unit test, integration test, etc.).

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Yes, I tested the github action changes by pushing this PR to my fork's
`main` and then push a new tag, with some minor changes so that the
github action can run succesfully.
The tag push triggered the `Publish` workflow
(https://github.com/kevinjqliu/iceberg-rust/actions/runs/15265739052)
which ran successfully and triggered the `Publish Python 🐍 distribution
📦 to PyPI` workflow
(https://github.com/kevinjqliu/iceberg-rust/actions/runs/15265757444)

Author: kevinjqliu

.github/workflows/release_python.yml

@@ -18,14 +18,10 @@
 name: Publish Python 🐍 distribution 📦 to PyPI
 
 on:
-  push:
-    tags:
-      - "*"
-  pull_request:
-    branches:
-      - main
-    paths:
-      - ".github/workflows/release_python.yml"
+  workflow_run:
+    workflows: ["Publish"] # Trigger this workflow after the "publish.yml" workflow completes
+    types:
+      - completed
   workflow_dispatch:
 
 env:
@@ -39,8 +35,16 @@ permissions:
   contents: read
 
 jobs:
+  check-cargo-publish:
+    runs-on: ubuntu-latest
+    # Only run if the triggering workflow succeeded OR if manually triggered
+    if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }}
+    steps:
+      - run: echo 'The Publish workflow passed or was manually triggered'
+
   sdist:
     runs-on: ubuntu-latest
+    needs: [check-cargo-publish]
     steps:
       - uses: actions/checkout@v4
       - uses: PyO3/maturin-action@v1
@@ -56,6 +60,7 @@ jobs:
 
   wheels:
     runs-on: "${{ matrix.os }}"
+    needs: [check-cargo-publish]
     strategy:
       matrix:
         include:
@@ -94,8 +99,8 @@ jobs:
     name: Publish Python 🐍 distribution 📦 to Pypi
     needs: [sdist, wheels]
     runs-on: ubuntu-latest
-    # Only publish to PyPi if the tag is not a pre-release
-    if: ${{ startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-') }}
+    # Only publish to PyPi if the tag is not a pre-release OR if manually triggered
+    if: ${{ (startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')) || github.event_name == 'workflow_dispatch' }}
 
     environment:
       name: pypi

Cargo.lock

@@ -90,7 +90,6 @@ zstd = { workspace = true }
 [dev-dependencies]
 ctor = { workspace = true }
 expect-test = { workspace = true }
-iceberg-catalog-memory = { workspace = true }
 iceberg_test_utils = { path = "../test_utils", features = ["tests"] }
 pretty_assertions = { workspace = true }
 rand = { workspace = true }

crates/iceberg/Cargo.toml

@@ -21,7 +21,9 @@
 //!
 //! ## Scan A Table
 //!
-//! ```rust, no_run
+//! ```rust, ignore
+//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
+//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
 //! use futures::TryStreamExt;
 //! use iceberg::io::{FileIO, FileIOBuilder};
 //! use iceberg::{Catalog, Result, TableIdent};

crates/iceberg/src/lib.rs

@@ -38,7 +38,9 @@
 //! own writer and implement writer trait for them so that the custom writer can integrate with existing writer. (See following example)
 //!
 //! # Simple example for the data file writer used parquet physical format:
-//! ```rust, no_run
+//! ```rust, ignore
+//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
+//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
 //! use std::sync::Arc;
 //!
 //! use arrow_array::{ArrayRef, BooleanArray, Int32Array, RecordBatch, StringArray};
@@ -95,7 +97,9 @@
 //! ```
 //!
 //! # Custom writer to record latency
-//! ```rust, no_run
+//! ```rust, ignore
+//! // This example uses `iceberg_catalog_memory`, which isn't enabled by default.
+//! // To run this, add `iceberg-catalog-memory` as a dependency in your Cargo.toml.
 //! use std::time::Instant;
 //!
 //! use arrow_array::RecordBatch;