Merge pull request #380 from raboof/fix-clean_actions

dfoulks1 · web-flow · commit 05657263d099 · 2025-12-01T07:36:30.000-05:00
gateway: fix clean_actions. LGTM
diff --git a/gateway/gateway.py b/gateway/gateway.py
@@ -290,7 +290,7 @@ def remove_expired_refs(actions: ActionsYAML):
         refs_to_remove.extend(
             (name, ref)
             for ref, details in action.items()
-            if "expires_at" in details and details["expires_at"] <= date.today() and not details.get("keep")
+            if details and "expires_at" in details and details["expires_at"] <= date.today() and not details.get("keep")
         )
 
     # Changing the iterable during iteration raises a RuntimeError

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ def remove_expired_refs(actions: ActionsYAML):`
`290`	`290`	`refs_to_remove.extend(`
`291`	`291`	`(name, ref)`
`292`	`292`	`for ref, details in action.items()`
`293`		`- if "expires_at" in details and details["expires_at"] <= date.today() and not details.get("keep")`
	`293`	`+ if details and "expires_at" in details and details["expires_at"] <= date.today() and not details.get("keep")`
`294`	`294`	`)`
`295`	`295`
`296`	`296`	`# Changing the iterable during iteration raises a RuntimeError`