Skip to content

Introduce parameter failOnMismatchedAllowedViolationsCount #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanEckert
Copy link

@NathanEckert NathanEckert commented Jan 27, 2025

This parameter allows to fail the build when the the actual number of violations is less than the max number of violations.

fixes #174

I did not open a Jira account as the change is small (17 lines without the tests)

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCHECKSTYLE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…e build when the max number of violations is not equal to the actual number of violations but is less
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a new user visible parameter is significant enough to require a JIRA issue.

@slawekjaranowski
Copy link
Member

I think a new user visible parameter is significant enough to require a JIRA issue.

We have switched to GitHub Issues .... with this project 😄
According to: https://maven.apache.org/developers/conventions/github.html we don't require a issue for each PR when we can discuss change.

@elharo
Copy link
Contributor

elharo commented May 5, 2025

Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes.

@NathanEckert
Copy link
Author

Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes.

I created #174

@elharo
Copy link
Contributor

elharo commented May 5, 2025

I also noticed that the template still says "Make sure there is a JIRA issue filed". We should probably fix that (not in this PR of course)

@slawekjaranowski
Copy link
Member

Github issue then. You are correct not all PRs require issues. However we should have an issue for user visible functionality changes for the release notes.

As we have wrote at https://maven.apache.org/developers/conventions/github.html
Only Pull Requests with status Merged will be visible in Release Notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce parameter failOnMismatchedAllowedViolationsCount
3 participants