[WAGON-599] Wagon-HTTP, set content-type when determinable from file extension

[jira-importer]

Christopher Beckey opened WAGON-599 and commented

Add determination of content type from file extension when sending from File, using javax.activation.MimetypesFileTypeMap.

---

Affects: 3.4.1

Remote Links:

• GitHub Pull Request #72
  

1 votes, 4 watchers

[jira-importer]

Michael Osipov commented

Can you describe your usecase?

[jira-importer]

Christopher Beckey commented

Specifically this came from needing AWS to retain the correct content-type when deploying the project site. We have our project site in S3, behind a CloudFront Distribution (to provide security). If the content-type is not specified when deploying the site then CloudFront defaults it to application.octet-stream, the result is that every file on the site is downloaded rather than displayed when accessed in a browser.

I have the code just about complete, a PR will be available in a few minutes. The PR includes conditionals such that:

1. the content-type is not overridden if it has been set
2. the content-type is written only when a system property (maven.wagon.http.file.autocontenttype) is set, the default behavior is consistent with current behavior
3. the content-type is only written if it was determinable (not null or empty) from the javax.activation.MimetypesFileTypeMap instance

[jira-importer]

Christopher Beckey commented

#72

[jira-importer]

Christopher Beckey commented

This is the plugin element from the project which is deploying its site:

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-site-plugin</artifactId>
<version>3.9.1</version>
<dependencies>
<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-webdav-jackrabbit</artifactId>
<!-- <version>2.10</version>-->
<version>3.4.1</version>
</dependency>
<!-- javax.activation was removed in Java 11 and after, it is required for webdav wagon -->
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>javax.activation</artifactId>
<version>1.2.0</version>
</dependency>
</dependencies>
</plugin>

[jira-importer]

Michael Osipov commented

Do you think you can write also a test case which depicts your new feature?